From: David Sterba <dsterba@suse.cz>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org, zab@redhat.com
Subject: Re: [PATCH] btrfs-progs: per-thread, per-call pretty buffer
Date: Wed, 10 Jul 2013 17:51:46 +0200 [thread overview]
Message-ID: <20130710155146.GC25386@twin.jikos.cz> (raw)
In-Reply-To: <F21C2CD4-347F-469F-99A8-BE41D0B530A2@gmail.com>
On Wed, Jul 10, 2013 at 11:31:17PM +0800, Wang Shilong wrote:
> Hello David,
>
> > From: Zach Brown <zab@redhat.com>
> >
> duplicate information.
git-send-email tricked me, the line is not present in thre tree
>
> > From: Zach Brown <zab@redhat.com>
> >
> > We don't need callers to manage string storage for each pretty_sizes()
> > call. We can use a macro to have per-thread and per-call static storage
> > so that pretty_sizes() can be used as many times as needed in printf()
> > arguments without requiring a bunch of supporting variables.
> >
> > This lets us have a natural interface at the cost of requiring __thread
> > and TLS from gcc and a small amount of static storage. This seems
> > better than the current code or doing something with illegible format
> > specifier macros.
> >
> > Signed-off-by: Zach Brown <zab@redhat.com>
> > Signed-off-by: David Sterba <dsterba@suse.cz>
>
> OK. please add my tag: Acked-by: Wang Shilong <wangs.fnst@cn.fujitsu.com>
> (I have given my tag in the previous thread to Zach and cc to you!)
>
> Zach gives a better solution,but i at least report and try for it. Isn't it?
Oh sorry, I'll add the tag of course, I was so excited with zach's patch
and missed it.
david
next prev parent reply other threads:[~2013-07-10 15:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 9:58 [PATCH V2 1/2] Btrfs-progs: make pretty_sizes() work less error prone Wang Shilong
2013-07-09 20:24 ` Zach Brown
2013-07-09 23:05 ` Wang Shilong
2013-07-10 12:49 ` David Sterba
2013-07-10 15:59 ` Zach Brown
2013-07-10 14:30 ` [PATCH] btrfs-progs: per-thread, per-call pretty buffer David Sterba
2013-07-10 15:31 ` Wang Shilong
2013-07-10 15:51 ` David Sterba [this message]
2013-07-10 16:16 ` Hugo Mills
2013-07-10 17:39 ` David Sterba
2013-07-10 17:40 ` [PATCH] btrfs-progs: use IEC units for sizes David Sterba
2014-09-04 11:43 ` [PATCH] btrfs-progs: per-thread, per-call pretty buffer Anand Jain
2014-09-04 19:45 ` Zach Brown
2014-09-05 7:11 ` Anand Jain
2014-09-05 15:55 ` Zach Brown
2014-09-05 16:20 ` David Sterba
2014-09-15 12:27 ` David Sterba
2015-02-27 17:53 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710155146.GC25386@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangshilong1991@gmail.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.