From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] intel_get_llc_size: Small tool to query LLC
 size
Date: Wed, 10 Jul 2013 19:45:00 +0200
Message-ID: <20130710174500.GI6143@phenom.ffwll.local>
References: <1373425083-1276-1-git-send-email-ben@bwidawsk.net>
	<1373425083-1276-2-git-send-email-ben@bwidawsk.net>
	<20130710063418.GH18285@phenom.ffwll.local>
	<20130710165838.GB3326@bwidawsk.net>
	<20130710171543.GH6143@phenom.ffwll.local>
	<20130710172427.GE3326@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com
	[209.85.215.179])
	by gabe.freedesktop.org (Postfix) with ESMTP id D4B9AE5C05
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Jul 2013 10:44:59 -0700 (PDT)
Received: by mail-ea0-f179.google.com with SMTP id b15so5119202eae.24
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Jul 2013 10:44:59 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130710172427.GE3326@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Bryan Bell <bryan.j.bell@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Jul 10, 2013 at 10:24:27AM -0700, Ben Widawsky wrote:
> On Wed, Jul 10, 2013 at 07:15:43PM +0200, Daniel Vetter wrote:
> > On Wed, Jul 10, 2013 at 09:58:38AM -0700, Ben Widawsky wrote:
> > > On Wed, Jul 10, 2013 at 08:34:18AM +0200, Daniel Vetter wrote:
> > > > On Tue, Jul 09, 2013 at 07:58:03PM -0700, Ben Widawsky wrote:
> > > > > CC: Chad Versace <chad.versace@linux.intel.com>
> > > > > CC: Bryan Bell <bryan.j.bell@intel.com>
> > > > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > > > 
> > > > So I think we should run this from igt and check its return value. And
> > > > since we've had a few bugs with other (currently untested) igt tools, can
> > > > you please add a new igt_tools testcase which just runs those? I'm
> > > > thinking of intel_reg_dumper and intel_reg_read (with some render ring
> > > > register that exists everywhere) on top of running intel_get_llc_size
> > > > here.
> > > 
> > > What would you like exactly for the check? Just to make sure platforms
> > > that should have LLC return a value > 1?
> > 
> > Just check that it runs without an non-zero exit code.
> 
> That doesn't really check the interface works as advertised though. Same
> for the below.

It checks more than nothing and at least in the case of reg IO breakage in
the past that was good enough to catch things.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch