From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754880Ab3GJUB6 (ORCPT ); Wed, 10 Jul 2013 16:01:58 -0400 Received: from mail.skyhub.de ([78.46.96.112]:52197 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051Ab3GJUB4 (ORCPT ); Wed, 10 Jul 2013 16:01:56 -0400 Date: Wed, 10 Jul 2013 22:01:39 +0200 From: Borislav Petkov To: Markus Trippelsdorf Cc: Geert Uytterhoeven , Kyungsik Lee , Andrew Morton , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild , the arch/x86 maintainers , CE Linux Developers List , "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Russell King , Florian Fainelli , Yann Collet , Chanho Min , Linux-Next , "uclinux-dist-devel@blackfin.uclinux.org" Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Message-ID: <20130710200139.GC9140@pd.tnic> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130506095124.GA22041@pd.tnic> <20130710093642.GC14873@pd.tnic> <20130710182815.GA362@x4> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130710182815.GA362@x4> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote: > Well, there's also no hand-holding when lzop is missing for LZO. And > the error message is clear enough. No? Actually, we should error out more gracefully than that. Maybe check for the presence of the executable first and if not, exit out of the build with an informational message that lz4c is not present on the system. Ditto for lzop. Currently, you wait for the whole build to complete just to see that there's no executable at the end. Not nice. > BTW speaking of introductory-level patches, what about the following > one: > > Now that lz4 kernel compression is available, add *.lz4 to .gitignore Yep. That makes sense. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([78.46.96.112]:52197 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051Ab3GJUB4 (ORCPT ); Wed, 10 Jul 2013 16:01:56 -0400 Date: Wed, 10 Jul 2013 22:01:39 +0200 From: Borislav Petkov Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Message-ID: <20130710200139.GC9140@pd.tnic> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130506095124.GA22041@pd.tnic> <20130710093642.GC14873@pd.tnic> <20130710182815.GA362@x4> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130710182815.GA362@x4> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Markus Trippelsdorf Cc: Geert Uytterhoeven , Kyungsik Lee , Andrew Morton , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild , the arch/x86 maintainers , CE Linux Developers List , "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Russell King , Florian Fainelli , Yann Collet , Chanho Min , Linux-Next , "uclinux-dist-devel@blackfin.uclinux.org" On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote: > Well, there's also no hand-holding when lzop is missing for LZO. And > the error message is clear enough. No? Actually, we should error out more gracefully than that. Maybe check for the presence of the executable first and if not, exit out of the build with an informational message that lz4c is not present on the system. Ditto for lzop. Currently, you wait for the whole build to complete just to see that there's no executable at the end. Not nice. > BTW speaking of introductory-level patches, what about the following > one: > > Now that lz4 kernel compression is available, add *.lz4 to .gitignore Yep. That makes sense. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Date: Wed, 10 Jul 2013 22:01:39 +0200 Message-ID: <20130710200139.GC9140@pd.tnic> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130506095124.GA22041@pd.tnic> <20130710093642.GC14873@pd.tnic> <20130710182815.GA362@x4> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:52197 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754051Ab3GJUB4 (ORCPT ); Wed, 10 Jul 2013 16:01:56 -0400 Content-Disposition: inline In-Reply-To: <20130710182815.GA362@x4> Sender: linux-next-owner@vger.kernel.org List-ID: To: Markus Trippelsdorf Cc: Geert Uytterhoeven , Kyungsik Lee , Andrew Morton , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild , the arch/x86 maintainers , CE Linux Developers List , "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Russell King , Florian Fainelli , Yann Collet , Chanho Min , Linux-Next , "uclinux-dist-devel@blackfin.uclinux.org" On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote: > Well, there's also no hand-holding when lzop is missing for LZO. And > the error message is clear enough. No? Actually, we should error out more gracefully than that. Maybe check for the presence of the executable first and if not, exit out of the build with an informational message that lz4c is not present on the system. Ditto for lzop. Currently, you wait for the whole build to complete just to see that there's no executable at the end. Not nice. > BTW speaking of introductory-level patches, what about the following > one: > > Now that lz4 kernel compression is available, add *.lz4 to .gitignore Yep. That makes sense. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Wed, 10 Jul 2013 22:01:39 +0200 Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format In-Reply-To: <20130710182815.GA362@x4> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130506095124.GA22041@pd.tnic> <20130710093642.GC14873@pd.tnic> <20130710182815.GA362@x4> Message-ID: <20130710200139.GC9140@pd.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 10, 2013 at 08:28:15PM +0200, Markus Trippelsdorf wrote: > Well, there's also no hand-holding when lzop is missing for LZO. And > the error message is clear enough. No? Actually, we should error out more gracefully than that. Maybe check for the presence of the executable first and if not, exit out of the build with an informational message that lz4c is not present on the system. Ditto for lzop. Currently, you wait for the whole build to complete just to see that there's no executable at the end. Not nice. > BTW speaking of introductory-level patches, what about the following > one: > > Now that lz4 kernel compression is available, add *.lz4 to .gitignore Yep. That makes sense. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --