From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UxckW-0006P2-WB
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 08:47:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UxckV-00053V-Mk
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 08:47:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13124)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UxckV-00053R-Fs
	for qemu-devel@nongnu.org; Fri, 12 Jul 2013 08:46:59 -0400
Date: Fri, 12 Jul 2013 08:46:55 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130712084655.07fea5bb@redhat.com>
In-Reply-To: <51DFA8FB.4000703@redhat.com>
References: <1373478767-20965-1-git-send-email-lcapitulino@redhat.com>
	<1373478767-20965-7-git-send-email-lcapitulino@redhat.com>
	<51DFA8FB.4000703@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 6/6] add timestamp to error_report()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, 12 Jul 2013 08:58:03 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 10/07/2013 19:52, Luiz Capitulino ha scritto:
> > From: Seiji Aguchi <seiji.aguchi@hds.com>
> > 
> > [Issue]
> > When we offer a customer support service and a problem happens
> > in a customer's system, we try to understand the problem by
> > comparing what the customer reports with message logs of the
> > customer's system.
> > 
> > In this case, we often need to know when the problem happens.
> > 
> > But, currently, there is no timestamp in qemu's error messages.
> > Therefore, we may not be able to understand the problem based on
> > error messages.
> > 
> > [Solution]
> > Add a timestamp to qemu's error message logged by
> > error_report() with g_time_val_to_iso8601().
> > 
> > Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> What about removing the option, and instead:
> 
> - logging no timestamp until the virtual machine has started

You mean, the guest has started? Why? What about if an error
happens before the guest has started?

> - always logging timestamps after the virtual machine has started

I don't like having this enabled by default, because it makes
error messages pretty verbose and also because it's not human
readable at a first glance. So, IMO, only people who really
want this should enable it.