From: Mark Brown <broonie@kernel.org>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Bo Shen <voice.shen@atmel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v5 1/7] sound: codec: wm8731: add rates constraints
Date: Fri, 12 Jul 2013 12:45:51 +0100 [thread overview]
Message-ID: <20130712114551.GD24508@sirena.org.uk> (raw)
In-Reply-To: <1373559359-31607-2-git-send-email-richard.genoud@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On Thu, Jul 11, 2013 at 06:15:53PM +0200, Richard Genoud wrote:
Please always try to use commit logs that look like normal commit logs
for the subsystem.
> switch (freq) {
> - case 11289600:
> case 12000000:
> + wm8731->constraints = &wm8731_constraints_12000000;
> + break;
> case 12288000:
> - case 16934400:
> case 18432000:
> - wm8731->sysclk = freq;
> + wm8731->constraints = &wm8731_constraints_12288000_18432000;
> + break;
> + case 16934400:
> + case 11289600:
> + wm8731->constraints = &wm8731_constraints_11289600_16934400;
> break;
> default:
> return -EINVAL;
> }
This isn't going to work with systems which have a variable clock as the
input to the CODEC. If it's imposing constraints the driver needs to
allow setting the clock to zero as a way of removing constraints (and
any existing drivers should be updated to do this if needed).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
devicetree-discuss@lists.ozlabs.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Bo Shen <voice.shen@atmel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/7] sound: codec: wm8731: add rates constraints
Date: Fri, 12 Jul 2013 12:45:51 +0100 [thread overview]
Message-ID: <20130712114551.GD24508@sirena.org.uk> (raw)
In-Reply-To: <1373559359-31607-2-git-send-email-richard.genoud@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 878 bytes --]
On Thu, Jul 11, 2013 at 06:15:53PM +0200, Richard Genoud wrote:
Please always try to use commit logs that look like normal commit logs
for the subsystem.
> switch (freq) {
> - case 11289600:
> case 12000000:
> + wm8731->constraints = &wm8731_constraints_12000000;
> + break;
> case 12288000:
> - case 16934400:
> case 18432000:
> - wm8731->sysclk = freq;
> + wm8731->constraints = &wm8731_constraints_12288000_18432000;
> + break;
> + case 16934400:
> + case 11289600:
> + wm8731->constraints = &wm8731_constraints_11289600_16934400;
> break;
> default:
> return -EINVAL;
> }
This isn't going to work with systems which have a variable clock as the
input to the CODEC. If it's imposing constraints the driver needs to
allow setting the clock to zero as a way of removing constraints (and
any existing drivers should be updated to do this if needed).
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/7] sound: codec: wm8731: add rates constraints
Date: Fri, 12 Jul 2013 12:45:51 +0100 [thread overview]
Message-ID: <20130712114551.GD24508@sirena.org.uk> (raw)
In-Reply-To: <1373559359-31607-2-git-send-email-richard.genoud@gmail.com>
On Thu, Jul 11, 2013 at 06:15:53PM +0200, Richard Genoud wrote:
Please always try to use commit logs that look like normal commit logs
for the subsystem.
> switch (freq) {
> - case 11289600:
> case 12000000:
> + wm8731->constraints = &wm8731_constraints_12000000;
> + break;
> case 12288000:
> - case 16934400:
> case 18432000:
> - wm8731->sysclk = freq;
> + wm8731->constraints = &wm8731_constraints_12288000_18432000;
> + break;
> + case 16934400:
> + case 11289600:
> + wm8731->constraints = &wm8731_constraints_11289600_16934400;
> break;
> default:
> return -EINVAL;
> }
This isn't going to work with systems which have a variable clock as the
input to the CODEC. If it's imposing constraints the driver needs to
allow setting the clock to zero as a way of removing constraints (and
any existing drivers should be updated to do this if needed).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130712/f6b906da/attachment.sig>
next prev parent reply other threads:[~2013-07-12 11:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 16:15 [PATCH v5 0/7] Sound support for at91sam9x5-wm8731 based boards Richard Genoud
2013-07-11 16:15 ` Richard Genoud
2013-07-11 16:15 ` [PATCH v5 1/7] sound: codec: wm8731: add rates constraints Richard Genoud
2013-07-11 16:15 ` Richard Genoud
2013-07-12 11:45 ` Mark Brown [this message]
2013-07-12 11:45 ` Mark Brown
2013-07-12 11:45 ` Mark Brown
2013-07-15 14:53 ` Richard Genoud
2013-07-15 14:53 ` Richard Genoud
2013-07-15 15:22 ` Mark Brown
2013-07-15 15:22 ` Mark Brown
2013-07-11 16:15 ` [PATCH v5 2/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud
2013-07-11 16:15 ` Richard Genoud
2013-07-12 11:49 ` Mark Brown
2013-07-12 11:49 ` Mark Brown
2013-07-12 11:49 ` Mark Brown
2013-07-15 14:59 ` Richard Genoud
2013-07-15 14:59 ` Richard Genoud
2013-07-11 16:15 ` [PATCH v5 3/7] Documentation: DT: update atmel SSC with DMA binding Richard Genoud
2013-07-11 16:15 ` Richard Genoud
2013-07-11 16:15 ` [PATCH v5 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud
2013-07-11 16:15 ` Richard Genoud
2013-07-11 16:15 ` [PATCH v5 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud
2013-07-11 16:15 ` Richard Genoud
2013-07-11 16:15 ` [PATCH v5 6/7] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud
2013-07-11 16:15 ` Richard Genoud
2013-07-11 16:15 ` [PATCH v5 7/7] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud
2013-07-11 16:15 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712114551.GD24508@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=richard.genoud@gmail.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.