All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	akpm@linux-foundation.org, jslaby@suse.cz, rpurdie@rpsys.net,
	linux-kernel@vger.kernel.org, Evan Broder <evan@ebroder.net>,
	Arnaud Patard <arnaud.patard@rtp-net.org>,
	Peter Korsgaard <jacmet@sunsite.dk>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Matt Sealey <matt@genesi-usa.com>,
	Rob Clark <robdclark@gmail.com>,
	Niels de Vos <devos@fedoraproject.org>,
	linux-arm-kernel@lists.infradead.org,
	Steev Klimaszewski <steev@genesi-usa.com>
Subject: Re: [PATCH] Route kbd LEDs through the generic LEDs layer
Date: Fri, 12 Jul 2013 14:42:42 +0200	[thread overview]
Message-ID: <20130712124242.GA5876@type> (raw)
In-Reply-To: <20130712113655.GA4227@amd.pavel.ucw.cz>

Pavel Machek, le Fri 12 Jul 2013 13:36:56 +0200, a écrit :
> > This permits to reassign keyboard LEDs to something else than keyboard "leds"
> > state, by adding keyboard led and modifier triggers connected to a series
> > of VT input LEDs, themselves connected to VT input triggers, which
> > per-input device LEDs use by default.  Userland can thus easily change the LED
> > behavior of (a priori) all input devices, or of particular input devices.
> 
> Nice! Leds now have proper /sys interface.
> 
> But... I boot up, switch from X to console, press capslock, and no
> reaction anywhere.

Is it working without the patch?  Console-setup for instance is known to
have broken the capslock LED, which is precisely one of the reasons for
this patch, which will provide console-setup with a way to bring back
caps lock working properly.

At any rate, please provide way more information about your keyboard
and LED configuration (output of dumpkeys, dmesg, content of
/sys/class/leds/*/trigger, etc.), as things are just working fine for me
(just like it has been for the past two years).

> Note that this is notebook with usb keyboard plugged in (and two
> monitors), but I believe this worked before...

Things work fine with my USB keyboard too, is this perhaps using an odd
driver which would not expose LEDs in a standard way?

Samuel

WARNING: multiple messages have this Message-ID (diff)
From: samuel.thibault@ens-lyon.org (Samuel Thibault)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Route kbd LEDs through the generic LEDs layer
Date: Fri, 12 Jul 2013 14:42:42 +0200	[thread overview]
Message-ID: <20130712124242.GA5876@type> (raw)
In-Reply-To: <20130712113655.GA4227@amd.pavel.ucw.cz>

Pavel Machek, le Fri 12 Jul 2013 13:36:56 +0200, a ?crit :
> > This permits to reassign keyboard LEDs to something else than keyboard "leds"
> > state, by adding keyboard led and modifier triggers connected to a series
> > of VT input LEDs, themselves connected to VT input triggers, which
> > per-input device LEDs use by default.  Userland can thus easily change the LED
> > behavior of (a priori) all input devices, or of particular input devices.
> 
> Nice! Leds now have proper /sys interface.
> 
> But... I boot up, switch from X to console, press capslock, and no
> reaction anywhere.

Is it working without the patch?  Console-setup for instance is known to
have broken the capslock LED, which is precisely one of the reasons for
this patch, which will provide console-setup with a way to bring back
caps lock working properly.

At any rate, please provide way more information about your keyboard
and LED configuration (output of dumpkeys, dmesg, content of
/sys/class/leds/*/trigger, etc.), as things are just working fine for me
(just like it has been for the past two years).

> Note that this is notebook with usb keyboard plugged in (and two
> monitors), but I believe this worked before...

Things work fine with my USB keyboard too, is this perhaps using an odd
driver which would not expose LEDs in a standard way?

Samuel

  reply	other threads:[~2013-07-12 12:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201011112205.oABM5KVJ005298@imap1.linux-foundation.org>
     [not found] ` <201011111440.07882.dmitry.torokhov@gmail.com>
     [not found]   ` <20110102090935.GV32469@atrey.karlin.mff.cuni.cz>
     [not found]     ` <20110102103210.GA25662@core.coreip.homeip.net>
     [not found]       ` <20110102225741.GX5480@const.famille.thibault.fr>
     [not found]         ` <20110112182702.GA9168@core.coreip.homeip.net>
2011-01-15 19:09           ` [patch 20/35] leds: route kbd LEDs through the generic LEDs layer Samuel Thibault
2011-11-14  4:06           ` Samuel Thibault
2012-02-06 14:19             ` Pavel Machek
2012-11-28 22:06               ` Samuel Thibault
2012-12-21  0:34             ` [PATCH] Route " Samuel Thibault
2012-12-21  0:34             ` Samuel Thibault
2012-12-21  0:34               ` Samuel Thibault
2013-07-07 10:10               ` Samuel Thibault
2013-07-07 10:10                 ` Samuel Thibault
2013-07-12 11:36                 ` Pavel Machek
2013-07-12 11:36                   ` Pavel Machek
2013-07-12 12:42                   ` Samuel Thibault [this message]
2013-07-12 12:42                     ` Samuel Thibault
2013-07-12 23:33                     ` Pavel Machek
2013-07-12 23:33                       ` Pavel Machek
2013-07-13  9:35                       ` Samuel Thibault
2013-07-13  9:35                         ` Samuel Thibault
2013-07-15  9:12                         ` Pavel Machek
2013-07-15  9:12                           ` Pavel Machek
2014-03-16 10:16                           ` Pali Rohár
2014-03-16 10:19                             ` Samuel Thibault
2014-03-27  1:08                               ` Pali Rohár
2014-03-28  7:01                                 ` 8 months to review a patch (was Re: [PATCH] Route kbd LEDs through the generic LEDs layer) Pavel Machek
2014-03-28  7:01                                   ` Pavel Machek
2014-03-28  7:17                                   ` Greg KH
2014-03-28  7:17                                     ` Greg KH
2014-04-06  9:43                                     ` Pali Rohár
2014-04-06  9:43                                       ` Pali Rohár
2014-04-06  9:55                                       ` Sebastian Reichel
2014-03-28  8:08                                   ` Samuel Thibault
2014-03-28  8:08                                     ` Samuel Thibault
2013-07-15  9:27                 ` [PATCH] Route kbd LEDs through the generic LEDs layer Peter Korsgaard
2013-07-15  9:27                   ` Peter Korsgaard
2013-07-15 15:03                 ` David Herrmann
2013-07-15 15:03                   ` David Herrmann
2013-07-15 19:08                   ` Samuel Thibault
2013-07-15 19:08                     ` Samuel Thibault
2013-07-17 15:14                     ` David Herrmann
2013-07-17 15:14                       ` David Herrmann
2010-02-24  1:20 [PATCH] Route kbd leds through the generic leds layer Samuel Thibault
  -- strict thread matches above, loose matches on Subject: below --
2010-02-24  1:20 Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130712124242.GA5876@type \
    --to=samuel.thibault@ens-lyon.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=devos@fedoraproject.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=evan@ebroder.net \
    --cc=jacmet@sunsite.dk \
    --cc=jslaby@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@genesi-usa.com \
    --cc=pavel@ucw.cz \
    --cc=robdclark@gmail.com \
    --cc=rpurdie@rpsys.net \
    --cc=s.hauer@pengutronix.de \
    --cc=steev@genesi-usa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.