From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964809Ab3GLMrT (ORCPT ); Fri, 12 Jul 2013 08:47:19 -0400 Received: from mail.skyhub.de ([78.46.96.112]:51720 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964794Ab3GLMrR (ORCPT ); Fri, 12 Jul 2013 08:47:17 -0400 Date: Fri, 12 Jul 2013 14:46:57 +0200 From: Borislav Petkov To: Florian Fainelli Cc: Andrew Morton , Ingo Molnar , Kyungsik Lee , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild@vger.kernel.org, x86@kernel.org, celinux-dev@lists.celinuxforum.org, "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Russell King , Yann Collet , Chanho Min , Linus Torvalds Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Message-ID: <20130712124657.GH24008@pd.tnic> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130712075602.GA4002@gmail.com> <20130712080145.GC24008@pd.tnic> <20130712101319.GA13421@gmail.com> <20130712102326.GE24008@pd.tnic> <20130712041810.53c86e5f.akpm@linux-foundation.org> <20130712121354.GG24008@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 12, 2013 at 01:34:38PM +0100, Florian Fainelli wrote: > Shall we provide a shell script wrapper for all of these compressor > commands which would test for the utility presence and issue a BIG FAT > WARNING if not, but still create the file not to make the kernel build > fail? I guess we could probably do this in the Makefile directly as > well. I don't know how that would work with the main kernel Makefile but we do those kinds of tests in perf before we build it so that we can save ourselves the time spent on a failed build: 2209001fd895e8932ae2c85bfca233758234499a. This should probably work if you add a prerequisite target which runs early in the build process and checks for all the userspace tools required for the build. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([78.46.96.112]:51720 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964794Ab3GLMrR (ORCPT ); Fri, 12 Jul 2013 08:47:17 -0400 Date: Fri, 12 Jul 2013 14:46:57 +0200 From: Borislav Petkov Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Message-ID: <20130712124657.GH24008@pd.tnic> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130712075602.GA4002@gmail.com> <20130712080145.GC24008@pd.tnic> <20130712101319.GA13421@gmail.com> <20130712102326.GE24008@pd.tnic> <20130712041810.53c86e5f.akpm@linux-foundation.org> <20130712121354.GG24008@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Florian Fainelli Cc: Andrew Morton , Ingo Molnar , Kyungsik Lee , Michal Marek , "linux-kernel@vger.kernel.org" , linux-kbuild@vger.kernel.org, x86@kernel.org, celinux-dev@lists.celinuxforum.org, "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Russell King , Yann Collet , Chanho Min , Linus Torvalds On Fri, Jul 12, 2013 at 01:34:38PM +0100, Florian Fainelli wrote: > Shall we provide a shell script wrapper for all of these compressor > commands which would test for the utility presence and issue a BIG FAT > WARNING if not, but still create the file not to make the kernel build > fail? I guess we could probably do this in the Makefile directly as > well. I don't know how that would work with the main kernel Makefile but we do those kinds of tests in perf before we build it so that we can save ourselves the time spent on a failed build: 2209001fd895e8932ae2c85bfca233758234499a. This should probably work if you add a prerequisite target which runs early in the build process and checks for all the userspace tools required for the build. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Fri, 12 Jul 2013 14:46:57 +0200 Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format In-Reply-To: References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <1367829775-4434-2-git-send-email-kyungsik.lee@lge.com> <20130712075602.GA4002@gmail.com> <20130712080145.GC24008@pd.tnic> <20130712101319.GA13421@gmail.com> <20130712102326.GE24008@pd.tnic> <20130712041810.53c86e5f.akpm@linux-foundation.org> <20130712121354.GG24008@pd.tnic> Message-ID: <20130712124657.GH24008@pd.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jul 12, 2013 at 01:34:38PM +0100, Florian Fainelli wrote: > Shall we provide a shell script wrapper for all of these compressor > commands which would test for the utility presence and issue a BIG FAT > WARNING if not, but still create the file not to make the kernel build > fail? I guess we could probably do this in the Makefile directly as > well. I don't know how that would work with the main kernel Makefile but we do those kinds of tests in perf before we build it so that we can save ourselves the time spent on a failed build: 2209001fd895e8932ae2c85bfca233758234499a. This should probably work if you add a prerequisite target which runs early in the build process and checks for all the userspace tools required for the build. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --