From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm/i915: Use the common register access functions for NOTRACE variants
Date: Fri, 12 Jul 2013 21:51:08 +0100 [thread overview]
Message-ID: <20130712205108.GF23323@cantiga.alporthouse.com> (raw)
In-Reply-To: <20130712203408.GH15384@bwidawsk.net>
On Fri, Jul 12, 2013 at 01:34:09PM -0700, Ben Widawsky wrote:
> On Fri, Jul 12, 2013 at 03:02:33PM +0100, Chris Wilson wrote:
> > #define __i915_write(x, y) \
> > -void i915_write##x(struct drm_i915_private *dev_priv, u32 reg, u##x val) { \
> > +void i915_write##x(struct drm_i915_private *dev_priv, u32 reg, u##x val, bool trace) { \
> > u32 __fifo_ret = 0; \
> > - trace_i915_reg_rw(true, reg, val, sizeof(val)); \
> > + if (trace) trace_i915_reg_rw(true, reg, val, sizeof(val)); \
> > if (NEEDS_FORCE_WAKE((dev_priv), (reg))) { \
> > __fifo_ret = __gen6_gt_wait_for_fifo(dev_priv); \
> > } \
>
>
> if (unlikely(trace))? taking a hit on the tracing case seems like what
> you want... but I never know the status of such compiler flags.
It would be likely, I guess. But it is not obvious, so leave it out. Later
on we replace it with the preferred form for conditional tracepoints.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-07-12 20:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 14:02 [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file Chris Wilson
2013-07-12 14:02 ` [PATCH 2/6] drm/i915: Use a private interface for register access within GT Chris Wilson
2013-07-12 20:25 ` Ben Widawsky
2013-07-12 20:55 ` Chris Wilson
2013-07-12 20:57 ` Daniel Vetter
2013-07-12 14:02 ` [PATCH 3/6] drm/i915: Use the common register access functions for NOTRACE variants Chris Wilson
2013-07-12 20:34 ` Ben Widawsky
2013-07-12 20:51 ` Chris Wilson [this message]
2013-07-12 14:02 ` [PATCH 4/6] drm/i915: Serialize all register access Chris Wilson
2013-07-12 20:37 ` Ben Widawsky
2013-07-12 20:52 ` Chris Wilson
2013-07-16 3:20 ` Ben Widawsky
2013-07-12 14:02 ` [PATCH 5/6] drm/i915: Squash gen lookup through multiple indirections inside GT access Chris Wilson
2013-07-12 14:02 ` [PATCH 6/6] drm/i915: Convert the register access tracepoint to be conditional Chris Wilson
2013-07-12 14:59 [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file Chris Wilson
2013-07-12 14:59 ` [PATCH 3/6] drm/i915: Use the common register access functions for NOTRACE variants Chris Wilson
2013-07-12 17:08 [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file Chris Wilson
2013-07-12 17:08 ` [PATCH 3/6] drm/i915: Use the common register access functions for NOTRACE variants Chris Wilson
2013-07-16 19:02 [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file Chris Wilson
2013-07-16 19:02 ` [PATCH 3/6] drm/i915: Use the common register access functions for NOTRACE variants Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712205108.GF23323@cantiga.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.