From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154Ab3GMJf6 (ORCPT ); Sat, 13 Jul 2013 05:35:58 -0400 Received: from toccata.ens-lyon.fr ([140.77.166.68]:51339 "EHLO toccata.ens-lyon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758Ab3GMJf4 (ORCPT ); Sat, 13 Jul 2013 05:35:56 -0400 Date: Sat, 13 Jul 2013 11:35:52 +0200 From: Samuel Thibault To: Pavel Machek Cc: Dmitry Torokhov , akpm@linux-foundation.org, jslaby@suse.cz, rpurdie@rpsys.net, linux-kernel@vger.kernel.org, Evan Broder , Arnaud Patard , Peter Korsgaard , Sascha Hauer , Matt Sealey , Rob Clark , Niels de Vos , linux-arm-kernel@lists.infradead.org, Steev Klimaszewski Subject: Re: [PATCH] Route kbd LEDs through the generic LEDs layer Message-ID: <20130713093552.GU8252@type> Mail-Followup-To: Samuel Thibault , Pavel Machek , Dmitry Torokhov , akpm@linux-foundation.org, jslaby@suse.cz, rpurdie@rpsys.net, linux-kernel@vger.kernel.org, Evan Broder , Arnaud Patard , Peter Korsgaard , Sascha Hauer , Matt Sealey , Rob Clark , Niels de Vos , linux-arm-kernel@lists.infradead.org, Steev Klimaszewski References: <20110102090935.GV32469@atrey.karlin.mff.cuni.cz> <20110102103210.GA25662@core.coreip.homeip.net> <20110102225741.GX5480@const.famille.thibault.fr> <20110112182702.GA9168@core.coreip.homeip.net> <20111114040613.GA4992@type.famille.thibault.fr> <20121221003449.GA6999@type.youpi.perso.aquilenet.fr> <20130707101028.GD5651@type.youpi.perso.aquilenet.fr> <20130712113655.GA4227@amd.pavel.ucw.cz> <20130712124242.GA5876@type> <20130712233301.GA3646@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130712233301.GA3646@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Machek, le Sat 13 Jul 2013 01:33:01 +0200, a écrit : > > > > This permits to reassign keyboard LEDs to something else than keyboard "leds" > > > > state, by adding keyboard led and modifier triggers connected to a series > > > > of VT input LEDs, themselves connected to VT input triggers, which > > > > per-input device LEDs use by default. Userland can thus easily change the LED > > > > behavior of (a priori) all input devices, or of particular input devices. > > > > > > Nice! Leds now have proper /sys interface. > > > > > > But... I boot up, switch from X to console, press capslock, and no > > > reaction anywhere. > > > > Is it working without the patch? Console-setup for instance is known to > > have broken the capslock LED, which is precisely one of the reasons for > > this patch, which will provide console-setup with a way to bring back > > caps lock working properly. > > You are right, it was broken before. Ok. You then may want fix your setup by configuring your caps lock led the way console-setup will be supposed to do in the future: echo ctrlllock > /sys/class/leds/vt::capsl/trigger Or some other of the locks that console-setup might be using to implement caps lock. > > Things work fine with my USB keyboard too, is this perhaps using an odd > > driver which would not expose LEDs in a standard way? > > No, everything works as well as it did. Feel free to add: > > Tested-by: Pavel Machek Thanks for testing, Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 From: samuel.thibault@ens-lyon.org (Samuel Thibault) Date: Sat, 13 Jul 2013 11:35:52 +0200 Subject: [PATCH] Route kbd LEDs through the generic LEDs layer In-Reply-To: <20130712233301.GA3646@amd.pavel.ucw.cz> References: <20110102090935.GV32469@atrey.karlin.mff.cuni.cz> <20110102103210.GA25662@core.coreip.homeip.net> <20110102225741.GX5480@const.famille.thibault.fr> <20110112182702.GA9168@core.coreip.homeip.net> <20111114040613.GA4992@type.famille.thibault.fr> <20121221003449.GA6999@type.youpi.perso.aquilenet.fr> <20130707101028.GD5651@type.youpi.perso.aquilenet.fr> <20130712113655.GA4227@amd.pavel.ucw.cz> <20130712124242.GA5876@type> <20130712233301.GA3646@amd.pavel.ucw.cz> Message-ID: <20130713093552.GU8252@type> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Pavel Machek, le Sat 13 Jul 2013 01:33:01 +0200, a ?crit : > > > > This permits to reassign keyboard LEDs to something else than keyboard "leds" > > > > state, by adding keyboard led and modifier triggers connected to a series > > > > of VT input LEDs, themselves connected to VT input triggers, which > > > > per-input device LEDs use by default. Userland can thus easily change the LED > > > > behavior of (a priori) all input devices, or of particular input devices. > > > > > > Nice! Leds now have proper /sys interface. > > > > > > But... I boot up, switch from X to console, press capslock, and no > > > reaction anywhere. > > > > Is it working without the patch? Console-setup for instance is known to > > have broken the capslock LED, which is precisely one of the reasons for > > this patch, which will provide console-setup with a way to bring back > > caps lock working properly. > > You are right, it was broken before. Ok. You then may want fix your setup by configuring your caps lock led the way console-setup will be supposed to do in the future: echo ctrlllock > /sys/class/leds/vt::capsl/trigger Or some other of the locks that console-setup might be using to implement caps lock. > > Things work fine with my USB keyboard too, is this perhaps using an odd > > driver which would not expose LEDs in a standard way? > > No, everything works as well as it did. Feel free to add: > > Tested-by: Pavel Machek Thanks for testing, Samuel