Re: [PATCH v2 1/2] powerpc/math-emu: move the flush FPU state function into do_mathemu

[Kevin Hao <haokexin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

On Fri, Jul 12, 2013 at 06:37:13PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2013-07-12 at 13:36 +0800, Kevin Hao wrote:
> > +       /*
> > +        * If we support a HW FPU, we need to ensure the FP state
> > +        * if flushed into the thread_struct before attempting
> > +        * emulation
> > +        */
> > +#ifdef CONFIG_PPC_FPU
> > +       flush_fp_to_thread(current);
> > +#endif
> > +
> 
> While at it, care to send a patch that defined an empty
> flush_fp_to_thread() in the header instead ?
> 
> ie, switch_to.h
> 
> #ifdef CONFIG_PPC_FPU
> extern void flush_fp_to_thread(struct task-struct *);
> #else
> static inline void flush_fp_to_thread(struct task-struct *) { };
> #endif
> 
> And get rid of the ifdef's here (and elsewhere if any) ?

Sure. Matt also pointed out a typo in the comments of this patch.
So I will respin a v3 for this. But since I also have some similar
clean up patches as the change you just suggested, I will send them
as a separate patch series instead of messing the v3.

Thanks,
Kevin

> 
> Thanks !
> 
> Cheers,
> Ben.
> 
> 

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]