From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932634Ab3GQQ5v (ORCPT ); Wed, 17 Jul 2013 12:57:51 -0400 Received: from mail-bk0-f49.google.com ([209.85.214.49]:34892 "EHLO mail-bk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756574Ab3GQQ5s (ORCPT ); Wed, 17 Jul 2013 12:57:48 -0400 Date: Wed, 17 Jul 2013 18:57:43 +0200 From: Robert Richter To: Linus Torvalds Cc: Russell King , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] arm, kbuild: make "make install" not depend on vmlinux Message-ID: <20130717165743.GK8731@rric.localhost> References: <20130710133742.GA29368@emu.suse.cz> <20130711135445.GA21500@sepie.suse.cz> <20130712105721.GF8731@rric.localhost> <20130717160506.GI8731@rric.localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.07.13 09:36:57, Linus Torvalds wrote: > On Wed, Jul 17, 2013 at 9:05 AM, Robert Richter wrote: > > > > I narrowed this down. The problem is that zinstall on ARCH=arm has a > > dependency to vmlinux which does a prepare/prepare3 and finally does a > > forced rebuild of kernel.release even if it exists already. > > > > Rebuilding it removes kernel.release first and then recreates it. This > > might race with another parallel make job running depmod. > > > > So on arm and maybe other archs we need the same as for x86: > > > > 1648e4f8 x86, kbuild: make "make install" not depend on vmlinux > > > > The patch below fixes this for arm. It is build-tested in my > > environment, but please test it in others too if possible. > > Ack. This looks like the right thing to do. Thanks for looking at this. > That said, I think for clarity you might perhaps want to make the > unrelated change of adding double quotes around $(KERNELRELEASE) a > separate patch. Not a big deal, but it took me a moment to say "why > did he do that" (in fact, I'm not sure KERNEL_RELEASE can actually > validly have spaces in it, but quoting it is certainly not wrong > either - but it might be unnecessary. If kernel.release doen't exist KERNEL_RELEASE is empty, thus all args for install.sh shift one arg left. Putting it in quotes avoids this. Noticed this since the first verified file in install.sh ($2) should be the image file but was already System.map ($3). Will splitt the patches and resend. -Robert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f49.google.com ([209.85.214.49]:34892 "EHLO mail-bk0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756574Ab3GQQ5s (ORCPT ); Wed, 17 Jul 2013 12:57:48 -0400 Date: Wed, 17 Jul 2013 18:57:43 +0200 From: Robert Richter Subject: Re: [PATCH] arm, kbuild: make "make install" not depend on vmlinux Message-ID: <20130717165743.GK8731@rric.localhost> References: <20130710133742.GA29368@emu.suse.cz> <20130711135445.GA21500@sepie.suse.cz> <20130712105721.GF8731@rric.localhost> <20130717160506.GI8731@rric.localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Russell King , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" On 17.07.13 09:36:57, Linus Torvalds wrote: > On Wed, Jul 17, 2013 at 9:05 AM, Robert Richter wrote: > > > > I narrowed this down. The problem is that zinstall on ARCH=arm has a > > dependency to vmlinux which does a prepare/prepare3 and finally does a > > forced rebuild of kernel.release even if it exists already. > > > > Rebuilding it removes kernel.release first and then recreates it. This > > might race with another parallel make job running depmod. > > > > So on arm and maybe other archs we need the same as for x86: > > > > 1648e4f8 x86, kbuild: make "make install" not depend on vmlinux > > > > The patch below fixes this for arm. It is build-tested in my > > environment, but please test it in others too if possible. > > Ack. This looks like the right thing to do. Thanks for looking at this. > That said, I think for clarity you might perhaps want to make the > unrelated change of adding double quotes around $(KERNELRELEASE) a > separate patch. Not a big deal, but it took me a moment to say "why > did he do that" (in fact, I'm not sure KERNEL_RELEASE can actually > validly have spaces in it, but quoting it is certainly not wrong > either - but it might be unnecessary. If kernel.release doen't exist KERNEL_RELEASE is empty, thus all args for install.sh shift one arg left. Putting it in quotes avoids this. Noticed this since the first verified file in install.sh ($2) should be the image file but was already System.map ($3). Will splitt the patches and resend. -Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: rric@kernel.org (Robert Richter) Date: Wed, 17 Jul 2013 18:57:43 +0200 Subject: [PATCH] arm, kbuild: make "make install" not depend on vmlinux In-Reply-To: References: <20130710133742.GA29368@emu.suse.cz> <20130711135445.GA21500@sepie.suse.cz> <20130712105721.GF8731@rric.localhost> <20130717160506.GI8731@rric.localhost> Message-ID: <20130717165743.GK8731@rric.localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17.07.13 09:36:57, Linus Torvalds wrote: > On Wed, Jul 17, 2013 at 9:05 AM, Robert Richter wrote: > > > > I narrowed this down. The problem is that zinstall on ARCH=arm has a > > dependency to vmlinux which does a prepare/prepare3 and finally does a > > forced rebuild of kernel.release even if it exists already. > > > > Rebuilding it removes kernel.release first and then recreates it. This > > might race with another parallel make job running depmod. > > > > So on arm and maybe other archs we need the same as for x86: > > > > 1648e4f8 x86, kbuild: make "make install" not depend on vmlinux > > > > The patch below fixes this for arm. It is build-tested in my > > environment, but please test it in others too if possible. > > Ack. This looks like the right thing to do. Thanks for looking at this. > That said, I think for clarity you might perhaps want to make the > unrelated change of adding double quotes around $(KERNELRELEASE) a > separate patch. Not a big deal, but it took me a moment to say "why > did he do that" (in fact, I'm not sure KERNEL_RELEASE can actually > validly have spaces in it, but quoting it is certainly not wrong > either - but it might be unnecessary. If kernel.release doen't exist KERNEL_RELEASE is empty, thus all args for install.sh shift one arg left. Putting it in quotes avoids this. Noticed this since the first verified file in install.sh ($2) should be the image file but was already System.map ($3). Will splitt the patches and resend. -Robert