From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 12/20] drm/gem: make drm_gem_object_handle_unreference_unlocked static Date: Wed, 17 Jul 2013 20:40:17 +0200 Message-ID: <20130717184017.GF4550@phenom.ffwll.local> References: <1373958731-4132-1-git-send-email-daniel.vetter@ffwll.ch> <1373958731-4132-13-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id C6262E5C6F for ; Wed, 17 Jul 2013 11:40:16 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id e52so1217287eek.38 for ; Wed, 17 Jul 2013 11:40:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: David Herrmann Cc: Daniel Vetter , DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, Jul 17, 2013 at 06:41:05PM +0200, David Herrmann wrote: > Hi > > On Tue, Jul 16, 2013 at 9:12 AM, Daniel Vetter wrote: > > No one outside of drm should use this, the official interfaces are > > drm_gem_handle_create and drm_gem_handle_delete. The handle refcounting > > is purely an implementation detail of gem. > > Yepp. Maybe we could even remove them as handle_reference() is only > called by handle_create(). Handle reference is already inlined in a previous patch. -Daniel > > Anyway: > Reviewed-by: David Herrmann > > Cheers > David > > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/drm/drm_gem.c | 2 +- > > include/drm/drmP.h | 1 - > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > > index 14c70b5..3b5305c 100644 > > --- a/drivers/gpu/drm/drm_gem.c > > +++ b/drivers/gpu/drm/drm_gem.c > > @@ -240,7 +240,7 @@ static void drm_gem_object_handle_free(struct drm_gem_object *obj) > > } > > } > > > > -void > > +static void > > drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj) > > { > > if (WARN_ON(obj->handle_count == 0)) > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > > index 25da8e0..1da1ca2 100644 > > --- a/include/drm/drmP.h > > +++ b/include/drm/drmP.h > > @@ -1670,7 +1670,6 @@ int drm_gem_handle_create(struct drm_file *file_priv, > > u32 *handlep); > > int drm_gem_handle_delete(struct drm_file *filp, u32 handle); > > > > -void drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj); > > > > void drm_gem_free_mmap_offset(struct drm_gem_object *obj); > > int drm_gem_create_mmap_offset(struct drm_gem_object *obj); > > -- > > 1.8.3.2 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch