All of lore.kernel.org
 help / color / mirror / Atom feed
From: "George Spelvin" <linux@horizon.com>
To: dhowells@redhat.com
Cc: joe@perches.com, linux@horizon.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] Add a generic associative array implementation.
Date: 17 Jul 2013 18:07:32 -0400	[thread overview]
Message-ID: <20130717220732.302.qmail@science.horizon.com> (raw)

I have to say, the entire boolean type seems strange.  I haven't looked at
all the users, but wouldn't it be better to provide some simple helpers
to allow call sites to set and test lsbits, and document the array as
requiring 2-byte alignment of pointers?

Factoring it into two features like this would eliminate a significant
source of API cruft for callers that don't use the feature, without
cluttering callers that do too much.

And callers could take advantage of known alignment to use more lsbits
if they wanted to.

             reply	other threads:[~2013-07-17 22:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 22:07 George Spelvin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-07-17 20:43 [RFC][PATCH 00/10] Associative array & Massive expansion of keyring capacity David Howells
2013-07-17 20:43 ` [PATCH 02/10] Add a generic associative array implementation David Howells
2013-07-17 20:53   ` Joe Perches
2013-07-17 21:01   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130717220732.302.qmail@science.horizon.com \
    --to=linux@horizon.com \
    --cc=dhowells@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.