From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 17 Jul 2013 23:04:56 +0000 Subject: Re: [PATCH] ARM: shmobile: r8a7740: Fix ethernet device name in clock definition Message-Id: <20130717230455.GB8154@verge.net.au> List-Id: References: <1373966374-15716-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1373966374-15716-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org [ Cc Magnus ] On Wed, Jul 17, 2013 at 03:11:16PM +0200, Laurent Pinchart wrote: > Hi Sergei, > > On Wednesday 17 July 2013 17:05:50 Sergei Shtylyov wrote: > > Hello. > > > > On 17-07-2013 14:47, Laurent Pinchart wrote: > > >>>> The ethernet device is named r8a7740-gether, fix the clock definition > > >>>> accordingly. > > >>>> > > >>>> Signed-off-by: Laurent Pinchart > > >>>> > > >>>> --- > > >>>> > > >>>> arch/arm/mach-shmobile/clock-r8a7740.c | 2 +- > > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>>> > > >>>> diff --git a/arch/arm/mach-shmobile/clock-r8a7740.c > > >>>> b/arch/arm/mach-shmobile/clock-r8a7740.c > > >>>> index de10fd7..e1e8710 100644 > > >>>> --- a/arch/arm/mach-shmobile/clock-r8a7740.c > > >>>> +++ b/arch/arm/mach-shmobile/clock-r8a7740.c > > >>>> @@ -595,7 +595,7 @@ static struct clk_lookup lookups[] = { > > >>>> > > >>>> CLKDEV_DEV_ID("sh_mmcif", &mstp_clks[MSTP312]), > > >>>> CLKDEV_DEV_ID("e6bd0000.mmcif", &mstp_clks[MSTP312]), > > >>>> CLKDEV_DEV_ID("r8a7740-gether", &mstp_clks[MSTP309]), > > >>>> > > >>>> - CLKDEV_DEV_ID("e9a00000.sh-eth", &mstp_clks[MSTP309]), > > >>>> + CLKDEV_DEV_ID("e9a00000.r8a7740-gether", &mstp_clks[MSTP309]), > > >>>> > > >>> Al Ethernet devices should be named "ethernet", according to ePAPR > > >>> spec. > > >> > > >> BTW, I'm not seeing a patch to r8a7740.dtsi, describing this device. > > > > > > Let's delay this patch until the device gets added to r8a7740.dtsi then. > > > > I don't see a use for this line even then. sh-eth.c can't be converted > > to device tree due to procedural platform data, so I'm planning to use > > OF_DEV_AUXDATA() for it which doesn't require defining an extra clock. > > The usage of OF_DEV_AUXDATA() is discouraged. A quick grep shows that the only > board code callback in sh_eth_plat_data (.set_mdio_gate) isn't used on ARM > platforms, so the driver should support pure DT bindings without auxiliary > data. Magnus has just spend some time removing auxdata. Please don't add it back in again.