[PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth

[PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth

[Kuninori Morimoto]

No one is using sh_eth on r8a7779 board.
remove it

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/mach-shmobile/include/mach/r8a7779.h |    1 -
 arch/arm/mach-shmobile/setup-r8a7779.c        |   20 --------------------
 2 files changed, 21 deletions(-)

diff --git a/arch/arm/mach-shmobile/include/mach/r8a7779.h b/arch/arm/mach-shmobile/include/mach/r8a7779.h
index f10727f7..213c3942 100644
--- a/arch/arm/mach-shmobile/include/mach/r8a7779.h
+++ b/arch/arm/mach-shmobile/include/mach/r8a7779.h
@@ -32,7 +32,6 @@ extern void r8a7779_earlytimer_init(void);
 extern void r8a7779_add_early_devices(void);
 extern void r8a7779_add_standard_devices(void);
 extern void r8a7779_add_standard_devices_dt(void);
-extern void r8a7779_add_ether_device(struct sh_eth_plat_data *pdata);
 extern void r8a7779_init_late(void);
 extern void r8a7779_clock_init(void);
 extern void r8a7779_pinmux_init(void);
diff --git a/arch/arm/mach-shmobile/setup-r8a7779.c b/arch/arm/mach-shmobile/setup-r8a7779.c
index 0863aa9..9f28b55 100644
--- a/arch/arm/mach-shmobile/setup-r8a7779.c
+++ b/arch/arm/mach-shmobile/setup-r8a7779.c
@@ -537,18 +537,6 @@ static struct platform_device ohci1_device = {
 	.resource	= ohci1_resources,
 };
 
-/* Ether */
-static struct resource ether_resources[] = {
-	{
-		.start	= 0xfde00000,
-		.end	= 0xfde003ff,
-		.flags	= IORESOURCE_MEM,
-	}, {
-		.start	= gic_iid(0xb4),
-		.flags	= IORESOURCE_IRQ,
-	},
-};
-
 static struct platform_device *r8a7779_devices_dt[] __initdata = {
 	&scif0_device,
 	&scif1_device,
@@ -584,14 +572,6 @@ void __init r8a7779_add_standard_devices(void)
 			    ARRAY_SIZE(r8a7779_standard_devices));
 }
 
-void __init r8a7779_add_ether_device(struct sh_eth_plat_data *pdata)
-{
-	platform_device_register_resndata(&platform_bus, "r8a777x-ether", -1,
-					  ether_resources,
-					  ARRAY_SIZE(ether_resources),
-					  pdata, sizeof(*pdata));
-}
-
 /* do nothing for !CONFIG_SMP or !CONFIG_HAVE_TWD */
 void __init __weak r8a7779_register_twd(void) { }
 
-- 
1.7.9.5

Re: [PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth

[Sergei Shtylyov]

On 11-07-2013 12:32, Kuninori Morimoto wrote:

> No one is using sh_eth on r8a7779 board.
> remove it

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    NAK.

WBR, Sergei

Re: [PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth

[Sergei Shtylyov]

Hello.

On 11-07-2013 15:39, Sergei Shtylyov wrote:

>> No one is using sh_eth on r8a7779 board.
>> remove it

    This may yet change (depends on information/support from Renesas), 
so this is a bit premature. And there's no r8a7779 board, there's Marzen 
(of the supported now boards).

>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

>     NAK.

    I've added it not to be removed 2 releases later. Quit creating 
churn please.

WBR, Sergei

Re: [PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth

[Simon Horman]

On Fri, Jul 12, 2013 at 03:20:52PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 11-07-2013 15:39, Sergei Shtylyov wrote:
> 
> >>No one is using sh_eth on r8a7779 board.
> >>remove it
> 
>    This may yet change (depends on information/support from
> Renesas), so this is a bit premature. And there's no r8a7779 board,
> there's Marzen (of the supported now boards).
> 
> >>Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> >    NAK.
> 
>    I've added it not to be removed 2 releases later. Quit creating
> churn please.

Is there any planned usage for this code, in say the next 3 releases?
If not I'm inclined to accept this patch. As its not being exercised it
could easily bit-rot. And it could easily be re-added if it is needed.

Re: [PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth

[Sergei Shtylyov]

Hello.

On 18-07-2013 3:15, Simon Horman wrote:

>>>> No one is using sh_eth on r8a7779 board.
>>>> remove it

>>     This may yet change (depends on information/support from
>> Renesas), so this is a bit premature. And there's no r8a7779 board,
>> there's Marzen (of the supported now boards).

>>>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

>>>     NAK.

>>     I've added it not to be removed 2 releases later. Quit creating
>> churn please.

> Is there any planned usage for this code, in say the next 3 releases?
> If not I'm inclined to accept this patch. As its not being exercised it
> could easily bit-rot. And it could easily be re-added if it is needed.

     Replied off-list.

WBR, Sergei