Re: [Qemu-devel] [PATCH v6] QEMUBH: make AioContext's bh re-entrant

From: Stefan Hajnoczi <stefanha@redhat.com>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v6] QEMUBH: make AioContext's bh re-entrant
Date: Thu, 18 Jul 2013 13:08:00 +0800	[thread overview]
Message-ID: <20130718050800.GB26971@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1373948938-2494-1-git-send-email-pingfank@linux.vnet.ibm.com>

On Tue, Jul 16, 2013 at 12:28:58PM +0800, Liu Ping Fan wrote:
> BH will be used outside big lock, so introduce lock to protect
> between the writers, ie, bh's adders and deleter. The lock only
> affects the writers and bh's callback does not take this extra lock.
> Note that for the same AioContext, aio_bh_poll() can not run in
> parallel yet.
> 
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> v6:
>   destroy ctx->bh_lock in aio_ctx_finalize()
> ---
>  async.c             | 33 +++++++++++++++++++++++++++++++--
>  include/block/aio.h |  7 +++++++
>  2 files changed, 38 insertions(+), 2 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan