From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59769)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UzhHP-0004bK-Gf
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 02:01:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UzhHN-0003n7-31
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 02:01:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UzhHM-0003n1-Rl
	for qemu-devel@nongnu.org; Thu, 18 Jul 2013 02:01:29 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6I61RjC006038
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 18 Jul 2013 02:01:27 -0400
Date: Thu, 18 Jul 2013 13:29:55 +0800
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130718052955.GD26971@stefanha-thinkpad.redhat.com>
References: <1374055057-31988-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1374055057-31988-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for
	enable_write_target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org

On Wed, Jul 17, 2013 at 05:57:37PM +0800, Fam Zheng wrote:
> s->qcow and s->qcow_filename are allocated but not freed on error. Fix the
> possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of
> bdrv_create() and also the one of enable_write_target().
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> 
> v2: Fix leak of s->qcow_filename, propagate returen value of
>     enable_write_target(). [Laszlo]
> 
> ---
>  block/vvfat.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan