From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uzhpl-0001xz-Id for qemu-devel@nongnu.org; Thu, 18 Jul 2013 02:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uzhpk-000678-D7 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 02:37:01 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:57282) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uzhpk-00066o-87 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 02:37:00 -0400 Received: by mail-wi0-f172.google.com with SMTP id c10so6270681wiw.5 for ; Wed, 17 Jul 2013 23:36:59 -0700 (PDT) Date: Thu, 18 Jul 2013 14:36:49 +0800 From: Stefan Hajnoczi Message-ID: <20130718063649.GB32036@stefanha-thinkpad.redhat.com> References: <1373544987-20613-1-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373544987-20613-1-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, ronniesahlberg@gmail.com On Thu, Jul 11, 2013 at 02:16:17PM +0200, Peter Lieven wrote: > this series adds logical block provisioning functions to the iscsi layer. > it also is the first step to the change of migration to coroutines in > block/iscsi. > > the changes to qemu-img and block migration have been split and will > follow in separte patches later. > > changes in v3: > - merge both block provision inquiries into one patch. explitely free the iscsi tasks after > the inquiry. limit the unmap to 128k blocks if the target returns max_unmap = 0xffffffff; > - in the coroutine framework free the scsi task in the caller not in the callback. also > change the iTask init as Kevin suggested. > - in iscsi_co_is_allocated() return unallocated only for ANCHORED and UNALLOACTED to avoid > a wrong return value if a new provisioning status is introduced. > - added new patch adding .bdrv_co_discard > - build .bdrv_co_write_zeroes on top of .bdrv_co_discard > - fixed a bug for -ENOSPC in iscsi_create() spotted by Kevin. > - remove support for misaligned nb_sectors in aio_readv > - add log message in error case to lun alignment checks > > Peter Lieven (10): > iscsi: add logical block provisioning information to iscsilun > iscsi: add .bdrv_co_is_allocated > iscsi: add .bdrv_co_discard > iscsi: add .bdrv_write_zeroes > block: add bdrv_write_zeroes() > block/raw: add bdrv_co_write_zeroes > iscsi: fix -ENOSPC in iscsi_create() > iscsi: factor out sector conversions > iscsi: remove support for misaligned nb_sectors in aio_readv > iscsi: assert that sectors are aligned to LUN blocksize > > block.c | 27 ++- > block/iscsi.c | 433 +++++++++++++++++++++++++++++++++++++------------ > block/raw.c | 8 + > include/block/block.h | 2 + > 4 files changed, 358 insertions(+), 112 deletions(-) Thanks, applied patches 5 & 6 to my block tree: https://github.com/stefanha/qemu/commits/block Stefan