From: Guenter Roeck <linux@roeck-us.net> To: Eduardo Valentin <eduardo.valentin@ti.com> Cc: devicetree-discuss@lists.ozlabs.org, wni@nvidia.com, l.stach@pengutronix.de, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org> Subject: Re: [RESEND PATCH V1 8/9] hwmon: lm75: expose to thermal fw via DT nodes Date: Thu, 18 Jul 2013 00:22:33 -0700 [thread overview] Message-ID: <20130718072233.GA11120@roeck-us.net> (raw) In-Reply-To: <1374074248-31690-9-git-send-email-eduardo.valentin@ti.com> On Wed, Jul 17, 2013 at 11:17:27AM -0400, Eduardo Valentin wrote: > This patch adds to lm75 temperature sensor the possibility > to expose itself as thermal zone device, registered on the > thermal framework. > > The thermal zone is built only if a device tree node > describing a thermal zone for this sensor is present > inside the lm75 DT node. Otherwise, the driver behavior > will be the same. > As mentioned before, your usage of devicetree information is clearly outside the scope for devicetree data. One clear guideline for devicetree data is that it is supposed to be usable across multiple operating systems. Your proposal is clearly operating system and even subsystem specific. It does _not_ describe hardware. NACK. Guenter > Cc: Jean Delvare <khali@linux-fr.org> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: lm-sensors@lm-sensors.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > drivers/hwmon/lm75.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index c03b490..0aa5e28 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -27,6 +27,8 @@ > #include <linux/hwmon-sysfs.h> > #include <linux/err.h> > #include <linux/mutex.h> > +#include <linux/thermal.h> > +#include <linux/of.h> > #include "lm75.h" > > > @@ -70,6 +72,7 @@ static const u8 LM75_REG_TEMP[3] = { > /* Each client has this additional data */ > struct lm75_data { > struct device *hwmon_dev; > + struct thermal_zone_device *tz; > struct mutex update_lock; > u8 orig_conf; > u8 resolution; /* In bits, between 9 and 12 */ > @@ -92,6 +95,19 @@ static struct lm75_data *lm75_update_device(struct device *dev); > > /* sysfs attributes for hwmon */ > > +static int lm75_read_temp(void *dev, unsigned long *temp) > +{ > + struct lm75_data *data = lm75_update_device(dev); > + > + if (IS_ERR(data)) > + return PTR_ERR(data); > + > + *temp = ((data->temp[0] >> (16 - data->resolution)) * 1000) >> > + (data->resolution - 8); > + > + return 0; > +} > + > static ssize_t show_temp(struct device *dev, struct device_attribute *da, > char *buf) > { > @@ -271,11 +287,23 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id) > goto exit_remove; > } > > + if (of_find_node_by_name(client->dev.of_node, "thermal_zone")) { > + data->tz = thermal_zone_of_device_register(&client->dev, > + &client->dev, > + lm75_read_temp); > + if (IS_ERR(data->tz)) { > + status = PTR_ERR(data->tz); > + goto exit_hwmon; > + } > + } > + > dev_info(&client->dev, "%s: sensor '%s'\n", > dev_name(data->hwmon_dev), client->name); > > return 0; > > +exit_hwmon: > + hwmon_device_unregister(data->hwmon_dev); > exit_remove: > sysfs_remove_group(&client->dev.kobj, &lm75_group); > return status; > @@ -285,6 +313,7 @@ static int lm75_remove(struct i2c_client *client) > { > struct lm75_data *data = i2c_get_clientdata(client); > > + thermal_zone_device_unregister(data->tz); > hwmon_device_unregister(data->hwmon_dev); > sysfs_remove_group(&client->dev.kobj, &lm75_group); > lm75_write_value(client, LM75_REG_CONF, data->orig_conf); > -- > 1.8.2.1.342.gfa7285d > >
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: Eduardo Valentin <eduardo.valentin@ti.com> Cc: devicetree-discuss@lists.ozlabs.org, wni@nvidia.com, l.stach@pengutronix.de, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org> Subject: Re: [lm-sensors] [RESEND PATCH V1 8/9] hwmon: lm75: expose to thermal fw via DT nodes Date: Thu, 18 Jul 2013 07:22:33 +0000 [thread overview] Message-ID: <20130718072233.GA11120@roeck-us.net> (raw) In-Reply-To: <1374074248-31690-9-git-send-email-eduardo.valentin@ti.com> On Wed, Jul 17, 2013 at 11:17:27AM -0400, Eduardo Valentin wrote: > This patch adds to lm75 temperature sensor the possibility > to expose itself as thermal zone device, registered on the > thermal framework. > > The thermal zone is built only if a device tree node > describing a thermal zone for this sensor is present > inside the lm75 DT node. Otherwise, the driver behavior > will be the same. > As mentioned before, your usage of devicetree information is clearly outside the scope for devicetree data. One clear guideline for devicetree data is that it is supposed to be usable across multiple operating systems. Your proposal is clearly operating system and even subsystem specific. It does _not_ describe hardware. NACK. Guenter > Cc: Jean Delvare <khali@linux-fr.org> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: lm-sensors@lm-sensors.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > drivers/hwmon/lm75.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index c03b490..0aa5e28 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -27,6 +27,8 @@ > #include <linux/hwmon-sysfs.h> > #include <linux/err.h> > #include <linux/mutex.h> > +#include <linux/thermal.h> > +#include <linux/of.h> > #include "lm75.h" > > > @@ -70,6 +72,7 @@ static const u8 LM75_REG_TEMP[3] = { > /* Each client has this additional data */ > struct lm75_data { > struct device *hwmon_dev; > + struct thermal_zone_device *tz; > struct mutex update_lock; > u8 orig_conf; > u8 resolution; /* In bits, between 9 and 12 */ > @@ -92,6 +95,19 @@ static struct lm75_data *lm75_update_device(struct device *dev); > > /* sysfs attributes for hwmon */ > > +static int lm75_read_temp(void *dev, unsigned long *temp) > +{ > + struct lm75_data *data = lm75_update_device(dev); > + > + if (IS_ERR(data)) > + return PTR_ERR(data); > + > + *temp = ((data->temp[0] >> (16 - data->resolution)) * 1000) >> > + (data->resolution - 8); > + > + return 0; > +} > + > static ssize_t show_temp(struct device *dev, struct device_attribute *da, > char *buf) > { > @@ -271,11 +287,23 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id) > goto exit_remove; > } > > + if (of_find_node_by_name(client->dev.of_node, "thermal_zone")) { > + data->tz = thermal_zone_of_device_register(&client->dev, > + &client->dev, > + lm75_read_temp); > + if (IS_ERR(data->tz)) { > + status = PTR_ERR(data->tz); > + goto exit_hwmon; > + } > + } > + > dev_info(&client->dev, "%s: sensor '%s'\n", > dev_name(data->hwmon_dev), client->name); > > return 0; > > +exit_hwmon: > + hwmon_device_unregister(data->hwmon_dev); > exit_remove: > sysfs_remove_group(&client->dev.kobj, &lm75_group); > return status; > @@ -285,6 +313,7 @@ static int lm75_remove(struct i2c_client *client) > { > struct lm75_data *data = i2c_get_clientdata(client); > > + thermal_zone_device_unregister(data->tz); > hwmon_device_unregister(data->hwmon_dev); > sysfs_remove_group(&client->dev.kobj, &lm75_group); > lm75_write_value(client, LM75_REG_CONF, data->orig_conf); > -- > 1.8.2.1.342.gfa7285d > > _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2013-07-18 7:22 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-17 15:17 [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-25 23:28 ` Rafael J. Wysocki 2013-07-25 23:28 ` [lm-sensors] [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling Rafael J. Wysocki 2013-07-26 13:27 ` [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Eduardo Valentin 2013-07-26 13:27 ` [lm-sensors] [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling Eduardo Valentin 2013-07-26 13:27 ` [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 2/9] thermal: hwmon: move hwmon support to single file Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 16:29 ` [lm-sensors] " R, Durgadoss 2013-07-17 16:29 ` R, Durgadoss 2013-07-17 16:29 ` R, Durgadoss 2013-07-17 15:17 ` [RESEND PATCH V1 3/9] thermal: thermal_core: allow binding with limits on bind_params Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 16:25 ` [lm-sensors] " R, Durgadoss 2013-07-17 16:25 ` [lm-sensors] [RESEND PATCH V1 3/9] thermal: thermal_core: allow binding with limits on bind_para R, Durgadoss 2013-07-17 16:25 ` [lm-sensors] [RESEND PATCH V1 3/9] thermal: thermal_core: allow binding with limits on bind_params R, Durgadoss 2013-07-17 15:17 ` [RESEND PATCH V1 4/9] arm: dts: flag omap4430 with needs-cooling for cpu node Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 5/9] thermal: introduce device tree parser Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 6/9] thermal: ti-soc-thermal: use thermal DT infrastructure Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 7/9] arm: dts: add omap4430 thermal data Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-17 15:17 ` [RESEND PATCH V1 8/9] hwmon: lm75: expose to thermal fw via DT nodes Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-18 5:33 ` Wei Ni 2013-07-18 5:33 ` [lm-sensors] " Wei Ni 2013-07-18 5:33 ` Wei Ni 2013-07-18 13:12 ` Eduardo Valentin 2013-07-18 13:12 ` [lm-sensors] " Eduardo Valentin 2013-07-18 13:12 ` Eduardo Valentin 2013-07-19 7:43 ` Wei Ni 2013-07-19 7:43 ` [lm-sensors] " Wei Ni 2013-07-19 7:43 ` Wei Ni 2013-07-18 7:22 ` Guenter Roeck [this message] 2013-07-18 7:22 ` [lm-sensors] " Guenter Roeck 2013-07-17 15:17 ` [RESEND PATCH V1 9/9] hwmon: tmp102: " Eduardo Valentin 2013-07-17 15:17 ` [lm-sensors] " Eduardo Valentin 2013-07-17 15:17 ` Eduardo Valentin 2013-07-18 7:23 ` Guenter Roeck 2013-07-18 7:23 ` [lm-sensors] " Guenter Roeck 2013-07-17 22:09 ` [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build Guenter Roeck 2013-07-17 22:09 ` Guenter Roeck 2013-07-18 13:53 ` Eduardo Valentin 2013-07-18 13:53 ` Eduardo Valentin 2013-07-18 13:53 ` Eduardo Valentin 2013-07-18 17:18 ` Stephen Warren 2013-07-18 17:18 ` Stephen Warren 2013-07-18 21:21 ` Guenter Roeck 2013-07-18 21:21 ` Guenter Roeck 2013-07-19 13:03 ` Eduardo Valentin 2013-07-19 13:03 ` Eduardo Valentin 2013-07-19 13:03 ` Eduardo Valentin 2013-07-19 18:48 ` Stephen Warren 2013-07-19 18:48 ` Stephen Warren 2013-07-21 11:08 ` Guenter Roeck 2013-07-21 11:08 ` Guenter Roeck 2013-07-21 11:08 ` Guenter Roeck 2013-07-22 19:43 ` Stephen Warren 2013-07-22 19:43 ` Stephen Warren 2013-07-22 21:46 ` Guenter Roeck 2013-07-22 21:46 ` Guenter Roeck 2013-07-18 21:11 ` Guenter Roeck 2013-07-18 21:11 ` Guenter Roeck 2013-07-18 21:11 ` Guenter Roeck 2013-07-19 13:38 ` Eduardo Valentin 2013-07-19 13:38 ` Eduardo Valentin 2013-07-19 13:38 ` Eduardo Valentin 2013-07-19 18:45 ` Stephen Warren 2013-07-19 18:45 ` Stephen Warren 2013-07-19 18:45 ` Stephen Warren 2013-07-19 18:56 ` Eduardo Valentin 2013-07-19 18:56 ` Eduardo Valentin 2013-07-19 18:56 ` Eduardo Valentin 2013-07-21 10:14 ` Guenter Roeck 2013-07-21 10:14 ` Guenter Roeck 2013-07-21 10:14 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130718072233.GA11120@roeck-us.net \ --to=linux@roeck-us.net \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=eduardo.valentin@ti.com \ --cc=khali@linux-fr.org \ --cc=l.stach@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lm-sensors@lm-sensors.org \ --cc=wni@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.