* [PATCH] regulator: core: Use the power efficient workqueue for delayed powerdown
@ 2013-07-18 10:53 Mark Brown
2013-07-18 10:56 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2013-07-18 10:53 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-kernel, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
There is no need to use a normal per-CPU workqueue for delayed power downs
as they're not timing or performance critical and waking up a core for them
would defeat some of the point.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/regulator/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index b6efead..6ef476f 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1891,8 +1891,9 @@ int regulator_disable_deferred(struct regulator *regulator, int ms)
rdev->deferred_disables++;
mutex_unlock(&rdev->mutex);
- ret = schedule_delayed_work(&rdev->disable_work,
- msecs_to_jiffies(ms));
+ ret = queue_delayed_work(system_power_efficient_wq,
+ &rdev->disable_work,
+ msecs_to_jiffies(ms));
if (ret < 0)
return ret;
else
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: core: Use the power efficient workqueue for delayed powerdown
2013-07-18 10:53 [PATCH] regulator: core: Use the power efficient workqueue for delayed powerdown Mark Brown
@ 2013-07-18 10:56 ` Viresh Kumar
2013-07-18 11:02 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2013-07-18 10:56 UTC (permalink / raw)
To: Mark Brown; +Cc: Liam Girdwood, linaro-kernel, linux-kernel, Mark Brown
On 18 July 2013 16:23, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> There is no need to use a normal per-CPU workqueue for delayed power downs
> as they're not timing or performance critical and waking up a core for them
> would defeat some of the point.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/regulator/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index b6efead..6ef476f 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1891,8 +1891,9 @@ int regulator_disable_deferred(struct regulator *regulator, int ms)
> rdev->deferred_disables++;
> mutex_unlock(&rdev->mutex);
>
> - ret = schedule_delayed_work(&rdev->disable_work,
> - msecs_to_jiffies(ms));
> + ret = queue_delayed_work(system_power_efficient_wq,
> + &rdev->disable_work,
> + msecs_to_jiffies(ms));
> if (ret < 0)
> return ret;
> else
Cool!! People have started to use this interface now :)
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: core: Use the power efficient workqueue for delayed powerdown
2013-07-18 10:56 ` Viresh Kumar
@ 2013-07-18 11:02 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-07-18 11:02 UTC (permalink / raw)
To: Viresh Kumar; +Cc: Liam Girdwood, linaro-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
On Thu, Jul 18, 2013 at 04:26:22PM +0530, Viresh Kumar wrote:
> Cool!! People have started to use this interface now :)
It could do with a bit more publicity - the only reason I heard of it is
that I queried what a version of it was doing in the middle of big.LITTLE
patches for the LSK and why it wasn't upstream.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-18 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-18 10:53 [PATCH] regulator: core: Use the power efficient workqueue for delayed powerdown Mark Brown
2013-07-18 10:56 ` Viresh Kumar
2013-07-18 11:02 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.