From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UztXX-0007fR-4S for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:07:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UztXU-0008HT-7k for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:06:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UztXT-0008HM-Vc for qemu-devel@nongnu.org; Thu, 18 Jul 2013 15:06:56 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6IJ6ssK002267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 15:06:54 -0400 Date: Thu, 18 Jul 2013 12:06:51 -0700 From: Ian Main Message-ID: <20130718190651.GC13675@gate.mains.priv> References: <1374091462-18391-1-git-send-email-imain@redhat.com> <1374091462-18391-2-git-send-email-imain@redhat.com> <51E823AF.6060200@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51E823AF.6060200@redhat.com> Subject: Re: [Qemu-devel] [PATCH V4 1/4] Implement sync modes for drive-backup. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On Thu, Jul 18, 2013 at 11:19:43AM -0600, Eric Blake wrote: > On 07/17/2013 02:04 PM, Ian Main wrote: > > This patch adds sync-modes to the drive-backup interface and > > implements the FULL, NONE and TOP modes of synchronization. > > > > FULL performs as before copying the entire contents of the drive > > while preserving the point-in-time using CoW. > > NONE only copies new writes to the target drive. > > TOP copies changes to the topmost drive image and preserves the > > point-in-time using CoW. > > > > > +++ b/qapi-schema.json > > @@ -1807,6 +1807,10 @@ > > # @format: #optional the format of the new destination, default is to > > # probe if @mode is 'existing', else the format of the source > > # > > +# @sync: what parts of the disk image should be copied to the destination > > +# (all the disk, only the sectors allocated in the topmost image, or > > +# only new I/O). > > +# > > # @mode: #optional whether and how QEMU should create a new image, default is > > # 'absolute-paths'. > > This hunk looks bogus; the 'DriveBackup' type already documents @sync as > of commit b53169e, which makes me suspect this hunk got misapplied > during rebasing. Did you check that? I know there was one bit of documentation missing that I fixed here. I also just did a clean rebase (git am) to kevin/block and it all applied fine. > > # > > diff --git a/qmp-commands.hx b/qmp-commands.hx > > index e075df4..f3f6b3d 100644 > > --- a/qmp-commands.hx > > +++ b/qmp-commands.hx > > @@ -957,6 +957,7 @@ Arguments: > > > > Example: > > -> { "execute": "drive-backup", "arguments": { "device": "drive0", > > + "sync": "full", > > "target": "backup.img" } } > > Ouch - commit b53169e made 'sync' mandatory, but forgot to update the > example to match; perhaps this hunk ought to be applied independently? That's up to you guys, I can split it out if needed. Ian