All of
 help / color / mirror / Atom feed
From: Jean Delvare <>
To: Andy Lutomirski <>
	Guenter Roeck <>,
	James Ralston
Subject: Re: [PATCH v3 4/4] eeprom: Add a MODULE_DEVICE_TABLE
Date: Thu, 18 Jul 2013 22:31:25 +0200	[thread overview]
Message-ID: <20130718223125.63e03635@endymion.delvare> (raw)
In-Reply-To: <>

Hi Andy,

On Thu, 18 Jul 2013 09:15:47 -0700, Andy Lutomirski wrote:
> at24 doesn't have .class=I2C_CLASS_SPD (and I still am not really a
> fan of the i2c class mechanism).

The class-based auto-detection has its merits but it's not the solution
to all problems.

.class=I2C_CLASS_SPD could be added to the at24 driver. If we ever want
to kill the legacy eeprom driver, we will have to do exactly that.

That being said this won't help in your case, as your bus driver does
not support the SMBus transaction (Receive Byte) used to probe for
EEPROM chips in address range 0x50-0x57.

> Shall I play with ways to get known
> DIMM-only busses to probe these things directly and instantiate with
> i2c_new_device(..., .type="spd")?  Do you have other plans for how
> probing should work?

You could indeed call i2c_new_probed_device() on addresses 0x50-0x57
at the end of your new i2c bus driver's probe function, in order to
instantiate spd devices. This function takes a probe function as a
parameter so you could use a transaction type supported (Read Byte.)

> (For background in case you haven't been following the rest of the
> thread: the Intel iMC (integrated memory controller) bus appears to
> have only DIMMs attached, so everything on the bus is either the host
> or is something attached to a DIMM.  The latter devices have
> well-defined addresses: four bits of type and three bits of slot
> number.  This makes it easy to probe accurately.  I'm not sure that
> the i2c core class mechanism is well-suited to this, it's easy to do
> manually.)

Ideally the BIOS/firmware/whatever would tell the OS which memory slots
are used so that the kernel can instantiate all I2C/SMBus slave devices
without even probing for them. I really wonder how many decades it will
take to Intel and co to come up with a complete device typology
description on the PC/x86_64 platfor, so that probing is finally

Jean Delvare

  parent reply	other threads:[~2013-07-18 20:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 20:53 [PATCH v3 0/4] iMC SMBUS, TSOD hwmon devices, and eeprom modalias Andy Lutomirski
     [not found] ` <>
2013-07-17 20:53   ` [PATCH v3 1/4] i2c: Add DIMM bus code Andy Lutomirski
     [not found]     ` <>
2013-07-17 22:23       ` Guenter Roeck
     [not found]         ` <>
2013-07-17 23:04           ` Andy Lutomirski
     [not found]             ` <>
2013-07-18  0:57               ` Andy Lutomirski
2013-07-17 20:53   ` [PATCH v3 2/4] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips Andy Lutomirski
2013-07-17 20:53   ` [PATCH v3 3/4] tsod: New hwmon driver for Temperature Sensors on DIMM Andy Lutomirski
     [not found]     ` <>
2013-07-17 22:19       ` Guenter Roeck
     [not found]         ` <>
2013-07-17 22:49           ` Andy Lutomirski
     [not found]             ` <>
2013-07-17 23:09               ` Guenter Roeck
     [not found]                 ` <>
2013-07-17 23:13                   ` Andy Lutomirski
2013-07-17 20:53   ` [PATCH v3 4/4] eeprom: Add a MODULE_DEVICE_TABLE Andy Lutomirski
     [not found]     ` <>
2013-07-18  7:11       ` Jean Delvare
     [not found]         ` <>
2013-07-18 16:15           ` Andy Lutomirski
     [not found]             ` <>
2013-07-18 20:31               ` Jean Delvare [this message]
     [not found]                 ` <>
2013-07-18 20:44                   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130718223125.63e03635@endymion.delvare \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.