From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V06w9-0002Ck-4v for qemu-devel@nongnu.org; Fri, 19 Jul 2013 05:25:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V06w8-0007bN-2Z for qemu-devel@nongnu.org; Fri, 19 Jul 2013 05:25:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V06mH-0003KM-9X for qemu-devel@nongnu.org; Fri, 19 Jul 2013 05:15:05 -0400 Date: Fri, 19 Jul 2013 11:14:56 +0200 From: Kevin Wolf Message-ID: <20130719091456.GD2992@dhcp-200-207.str.redhat.com> References: <1374136652-22567-1-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374136652-22567-1-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 18.07.2013 um 10:37 hat Peter Lieven geschrieben: > Signed-off-by: Peter Lieven > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index b560241..c7f0197 100644 > --- a/block.c > +++ b/block.c > @@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num, > > enabled = bs->io_limits_enabled; > bs->io_limits_enabled = false; > - ret = bdrv_read(bs, 0, buf, 1); > + ret = bdrv_read(bs, sector_num, buf, nb_sectors); > bs->io_limits_enabled = enabled; > return ret; > } Reviewed-by: Kevin Wolf The commit message would have deserved a comment about the impact. The only caller is passing 0 as sector_num and 1 as nb_sectors, so this doesn't change the behaviour in practice. (Which is the reason why it's not for qemu-stable.) Kevin