From: Mark Brown <broonie@kernel.org>
To: bardliao@realtek.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5640: add headset detection function
Date: Tue, 23 Jul 2013 14:00:16 +0100 [thread overview]
Message-ID: <20130723130016.GA9858@sirena.org.uk> (raw)
In-Reply-To: <1374562469-5190-1-git-send-email-bardliao@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 541 bytes --]
On Tue, Jul 23, 2013 at 02:54:29PM +0800, bardliao@realtek.com wrote:
> + * @codec: SoC audio codec device.
> + * @jack_insert: Jack insert or not.
> + *
> + * Detect whether is headset or not when jack inserted.
> + *
> + * Returns detect status.
> + */
> +int rt5640_headset_detect(struct snd_soc_codec *codec,
> + struct snd_soc_jack *jack, int jack_insert)
This doesn't look like it implements jack detection, it looks like it's
some sort of callback. I'd expect to see some sort of interrupt for
example...
What's going on here?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2013-07-23 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 6:54 [PATCH] ASoC: rt5640: add headset detection function bardliao
2013-07-23 13:00 ` Mark Brown [this message]
2013-07-25 3:36 ` Bard Liao
2013-07-25 9:15 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2013-07-08 6:33 bardliao
2013-07-08 11:26 ` Mark Brown
2013-07-08 13:12 ` Bard Liao
2013-07-08 13:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130723130016.GA9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.