From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934353Ab3GWVXi (ORCPT ); Tue, 23 Jul 2013 17:23:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40496 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932567Ab3GWVXf (ORCPT ); Tue, 23 Jul 2013 17:23:35 -0400 Date: Tue, 23 Jul 2013 14:23:34 -0700 From: Greg KH To: Tomasz Figa Cc: Mark Brown , Tomasz Figa , Kishon Vijay Abraham I , Alan Stern , Laurent Pinchart , Sylwester Nawrocki , Sascha Hauer , kyungmin.park@samsung.com, balbi@ti.com, jg1.han@samsung.com, s.nawrocki@samsung.com, kgene.kim@samsung.com, grant.likely@linaro.org, tony@atomide.com, arnd@arndb.de, swarren@nvidia.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, akpm@linux-foundation.org, balajitk@ti.com, george.cherian@ti.com, nsekhar@ti.com, olof@lixom.net, Stephen Warren , b.zolnierkie@samsung.com, Daniel Lezcano Subject: Re: [PATCH 01/15] drivers: phy: add generic PHY framework Message-ID: <20130723212334.GA21945@kroah.com> References: <1731726.KENstTPhkb@flatron> <20130723205007.GA27166@kroah.com> <1769609.rbAYfG9ir3@flatron> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1769609.rbAYfG9ir3@flatron> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: > > That's not so bad, as long as you let the phy core use whatever name it > > wants for the device when it registers it with sysfs. > > Yes, in regulator core consumer names are completely separated from this. > Regulator core simply assigns a sequential integer ID to each regulator > and registers /sys/class/regulator/regulator.ID for each regulator. Yes, that's fine. > > Use the name you > > are requesting as a "tag" or some such "hint" as to what the phy can be > > looked up by. > > > > Good luck handling duplicate "tags" :) > > The tag alone is not a key. Lookup key consists of two components, > consumer device name and consumer tag. What kind of duplicate tags can be > a problem here? Ok, I didn't realize it looked at both parts, that makes sense, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Tue, 23 Jul 2013 21:23:34 +0000 Subject: Re: [PATCH 01/15] drivers: phy: add generic PHY framework Message-Id: <20130723212334.GA21945@kroah.com> List-Id: References: <1731726.KENstTPhkb@flatron> <20130723205007.GA27166@kroah.com> <1769609.rbAYfG9ir3@flatron> In-Reply-To: <1769609.rbAYfG9ir3@flatron> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: > > That's not so bad, as long as you let the phy core use whatever name it > > wants for the device when it registers it with sysfs. > > Yes, in regulator core consumer names are completely separated from this. > Regulator core simply assigns a sequential integer ID to each regulator > and registers /sys/class/regulator/regulator.ID for each regulator. Yes, that's fine. > > Use the name you > > are requesting as a "tag" or some such "hint" as to what the phy can be > > looked up by. > > > > Good luck handling duplicate "tags" :) > > The tag alone is not a key. Lookup key consists of two components, > consumer device name and consumer tag. What kind of duplicate tags can be > a problem here? Ok, I didn't realize it looked at both parts, that makes sense, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 01/15] drivers: phy: add generic PHY framework Date: Tue, 23 Jul 2013 14:23:34 -0700 Message-ID: <20130723212334.GA21945@kroah.com> References: <1731726.KENstTPhkb@flatron> <20130723205007.GA27166@kroah.com> <1769609.rbAYfG9ir3@flatron> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1769609.rbAYfG9ir3@flatron> Sender: linux-doc-owner@vger.kernel.org To: Tomasz Figa Cc: Mark Brown , Tomasz Figa , Kishon Vijay Abraham I , Alan Stern , Laurent Pinchart , Sylwester Nawrocki , Sascha Hauer , kyungmin.park@samsung.com, balbi@ti.com, jg1.han@samsung.com, s.nawrocki@samsung.com, kgene.kim@samsung.com, grant.likely@linaro.org, tony@atomide.com, arnd@arndb.de, swarren@nvidia.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, akpm@linux-foundation.org, balajitk@ti.com, george.cherian@ti.com, nsekhar@ti.com, olof@lixom.net, Stephen Warren List-Id: linux-omap@vger.kernel.org On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: > > That's not so bad, as long as you let the phy core use whatever name it > > wants for the device when it registers it with sysfs. > > Yes, in regulator core consumer names are completely separated from this. > Regulator core simply assigns a sequential integer ID to each regulator > and registers /sys/class/regulator/regulator.ID for each regulator. Yes, that's fine. > > Use the name you > > are requesting as a "tag" or some such "hint" as to what the phy can be > > looked up by. > > > > Good luck handling duplicate "tags" :) > > The tag alone is not a key. Lookup key consists of two components, > consumer device name and consumer tag. What kind of duplicate tags can be > a problem here? Ok, I didn't realize it looked at both parts, that makes sense, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Tue, 23 Jul 2013 14:23:34 -0700 Subject: [PATCH 01/15] drivers: phy: add generic PHY framework In-Reply-To: <1769609.rbAYfG9ir3@flatron> References: <1731726.KENstTPhkb@flatron> <20130723205007.GA27166@kroah.com> <1769609.rbAYfG9ir3@flatron> Message-ID: <20130723212334.GA21945@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: > > That's not so bad, as long as you let the phy core use whatever name it > > wants for the device when it registers it with sysfs. > > Yes, in regulator core consumer names are completely separated from this. > Regulator core simply assigns a sequential integer ID to each regulator > and registers /sys/class/regulator/regulator.ID for each regulator. Yes, that's fine. > > Use the name you > > are requesting as a "tag" or some such "hint" as to what the phy can be > > looked up by. > > > > Good luck handling duplicate "tags" :) > > The tag alone is not a key. Lookup key consists of two components, > consumer device name and consumer tag. What kind of duplicate tags can be > a problem here? Ok, I didn't realize it looked at both parts, that makes sense, thanks. greg k-h