From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel
 managed pages
Date: Wed, 24 Jul 2013 12:35:59 +0300
Message-ID: <20130724093559.GD16400@redhat.com>
References: <6A3DF150A5B70D4F9B66A25E3F7C888D070D6E79@039-SN2MPN1-013.039d.mgd.msft.net>
 <ABD89368-97E2-4CC4-A6A1-FDD78DA074E2@suse.de>
 <51E7BE90.60300@windriver.com>
 <50683BE9-8BDD-4730-B866-F972BCF1EDD6@suse.de>
 <51E7C14C.6060600@windriver.com>
 <E7A150B3-7263-470E-ABF2-680B0FA4FE7D@suse.de>
 <51EF3B67.5060403@windriver.com>
 <597D9B3F-BCE8-4483-B485-3035D6D443AC@suse.de>
 <6A3DF150A5B70D4F9B66A25E3F7C888D070E17FA@039-SN2MPN1-013.039d.mgd.msft.net>
 <708AA5B2-2073-4D24-8B3C-23CC113594C2@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Bhushan Bharat-R65777 <R65777@freescale.com>,
	=?cp1255?B?IpN0aWVqdW4uY2hlbpQi?= <tiejun.chen@windriver.com>,
	"kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>,
	"kvm@vger.kernel.org list" <kvm@vger.kernel.org>,
	Wood Scott-B07421 <B07421@freescale.com>,
	Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <708AA5B2-2073-4D24-8B3C-23CC113594C2@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote:
> > Are not we going to use page_is_ram() from  e500_shadow_mas2_attrib() as Scott commented?
> 
> rWhy aren't we using page_is_ram() in kvm_is_mmio_pfn()?
> 
> 
Because it is much slower and, IIRC, actually used to build pfn map that allow
us to check quickly for valid pfn.

--
			Gleb.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Date: Wed, 24 Jul 2013 09:35:59 +0000
Subject: Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages
Message-Id: <20130724093559.GD16400@redhat.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <6A3DF150A5B70D4F9B66A25E3F7C888D070D6E79@039-SN2MPN1-013.039d.mgd.msft.net>
 <ABD89368-97E2-4CC4-A6A1-FDD78DA074E2@suse.de>
 <51E7BE90.60300@windriver.com>
 <50683BE9-8BDD-4730-B866-F972BCF1EDD6@suse.de>
 <51E7C14C.6060600@windriver.com>
 <E7A150B3-7263-470E-ABF2-680B0FA4FE7D@suse.de>
 <51EF3B67.5060403@windriver.com>
 <597D9B3F-BCE8-4483-B485-3035D6D443AC@suse.de>
 <6A3DF150A5B70D4F9B66A25E3F7C888D070E17FA@039-SN2MPN1-013.039d.mgd.msft.net>
 <708AA5B2-2073-4D24-8B3C-23CC113594C2@suse.de>
In-Reply-To: <708AA5B2-2073-4D24-8B3C-23CC113594C2@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Alexander Graf <agraf@suse.de>
Cc: Bhushan Bharat-R65777 <R65777@freescale.com>, =?cp1255?B?IpN0aWVqdW4uY2hlbpQi?= <tiejun.chen@windriver.com>, "kvm-ppc@vger.kernel.org" <kvm-ppc@vger.kernel.org>, "kvm@vger.kernel.org list" <kvm@vger.kernel.org>, Wood Scott-B07421 <B07421@freescale.com>, Paolo Bonzini <pbonzini@redhat.com>

On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote:
> > Are not we going to use page_is_ram() from  e500_shadow_mas2_attrib() as Scott commented?
> 
> rWhy aren't we using page_is_ram() in kvm_is_mmio_pfn()?
> 
> 
Because it is much slower and, IIRC, actually used to build pfn map that allow
us to check quickly for valid pfn.

--
			Gleb.