Re: [PATCH V8 14/15] perf tools: add a function to calculate sample event size

[Jiri Olsa <jolsa@redhat.com>]

On Thu, Jul 18, 2013 at 01:42:56PM +0300, Adrian Hunter wrote:

SNIP

> @@ -227,6 +227,8 @@ int perf_event__preprocess_sample(const union perf_event *self,
>  
>  const char *perf_event__name(unsigned int id);
>  
> +size_t perf_event__sample_event_size(const struct perf_sample *sample, u64 type,
> +				     u64 sample_regs_user);
>  int perf_event__synthesize_sample(union perf_event *event, u64 type,
>  				  u64 sample_regs_user,
>  				  const struct perf_sample *sample,
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 047ab02..7a5ff06 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1348,6 +1348,87 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
>  	return 0;
>  }
>  
> +size_t perf_event__sample_event_size(const struct perf_sample *sample, u64 type,
> +				     u64 sample_regs_user)
> +{
> +	size_t sz, result = sizeof(struct sample_event);
> +
> +	if (type & PERF_SAMPLE_IDENTIFIER)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_IP)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_TID)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_TIME)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_ADDR)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_ID)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_STREAM_ID)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_CPU)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_PERIOD)
> +		result += sizeof(u64);
> +
> +	if (type & PERF_SAMPLE_READ) {
> +		fprintf(stderr, "PERF_SAMPLE_READ is unsupported for now\n");
> +		result += 8192; /* To be on the safe side */
> +	}

There' a patchset pending to be merged that implements
PERF_SAMPLE_READ. I wonder which one makes it in first..
looser will have to update this code ;-)

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka