From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 090FA7F3F for ; Wed, 24 Jul 2013 18:00:15 -0500 (CDT) Date: Wed, 24 Jul 2013 18:00:14 -0500 From: Ben Myers Subject: Re: [PATCH 12/48] xfs: add CRC checking to dir2 leaf blocks Message-ID: <20130724230014.GU3111@sgi.com> References: <1370564771-4929-1-git-send-email-david@fromorbit.com> <1370564771-4929-13-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1370564771-4929-13-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Jun 07, 2013 at 10:25:35AM +1000, Dave Chinner wrote: > From: Dave Chinner > > This addition follows the same pattern as the dir2 block CRCs. > Seeing as both LEAF1 and LEAFN types need to changed at the same > time, this is a pretty large amount of change. leaf block headers > need to be abstracted away from the on-disk structures (struct > xfs_dir3_icleaf_hdr), as do the base leaf entry locations. > > This header abstract allows the in-core header and leaf entry > location to be passed around instead of the leaf block itself. This > saves a lot of converting individual variables from on-disk format > to host format where they are used, so there's a good chance that > the compiler will be able to produce much more optimal code as it's > not having to byteswap variables all over the place. > > Signed-off-by: Dave Chinner Looks good. Note that xfs_dir3_leafn_read_verify and xfs_dir3_leafn_write_verify are static in the kernel but not in userspace. Reviewed-by: Ben Myers _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs