All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Abhimanyu Kapur <abhimany@codeaurora.org>
Cc: Anton Vorontsov <anton@enomsg.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: power: reset: add msm restart support
Date: Mon, 29 Jul 2013 17:20:28 -0700	[thread overview]
Message-ID: <20130730002027.GD8868@codeaurora.org> (raw)
In-Reply-To: <1375136906-22501-1-git-send-email-abhimany@codeaurora.org>

On 07/29, Abhimanyu Kapur wrote:
> diff --git a/Documentation/devicetree/bindings/power_supply/msm-poweroff.txt b/Documentation/devicetree/bindings/power_supply/msm-poweroff.txt
> new file mode 100644
> index 0000000..de08480
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power_supply/msm-poweroff.txt
> @@ -0,0 +1,17 @@
> +MSM Poweroff Driver
> +
> +A power supply hold (ps-hold) bit is set to power the msm chipsets.
> +Clearing that bit enables us to restart/poweroff. The difference

s/enables us/allows us/ perhaps?

> +between poweroff and restart is determined by unique power manager IC
> +settings.
> +
> +Required Properties:
> +-compatible: "qcom,pshold"
> +-reg: Specifies the physical address of the ps-hold register
> +
> +Example:
> +
> +	restart@800820 {
> +		compatible = "qcom,pshold";
> +		reg = <0x00800820 0x4>;
> +	};
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 349e9ae..fa6178f 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -37,3 +37,9 @@ config POWER_RESET_VEXPRESS
>  	help
>  	  Power off and reset support for the ARM Ltd. Versatile
>  	  Express boards.
> +
> +config POWER_RESET_MSM
> +	bool "Qualcomm MSM power-off driver"
> +	depends on POWER_RESET && ARCH_MSM
> +	help
> +	  Power off and restart support for Qualcomm boards.

It looks like this Kconfig file is trying to be alphabetically
ordered. Please make sure that it's maintained.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2013-07-30  0:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 22:28 [PATCH] drivers: power: reset: add msm restart support Abhimanyu Kapur
2013-07-30  0:20 ` Stephen Boyd [this message]
2013-07-30  7:10 ` Ivan T. Ivanov
2013-07-31  0:05 Abhimanyu Kapur
2013-07-31  7:05 ` Stephen Boyd
2013-07-31  7:12 ` Ivan T. Ivanov
2013-08-09 18:52 ` Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730002027.GD8868@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=abhimany@codeaurora.org \
    --cc=anton@enomsg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.