From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Updated FarSync driver
Date: Wed, 31 Jul 2013 14:50:17 +0000 [thread overview]
Message-ID: <20130731145017.GH5002@mwanda> (raw)
In-Reply-To: <E603DC592C92B54A89CEF6B0919A0B1CA86BBBD5E2@SOLO.hq.farsitecommunications.com>
On Wed, Jul 31, 2013 at 02:55:50PM +0100, Kevin Curtis wrote:
> Hi Dan,
> I am fixing the errors and warning reported by checkpatch. I have quite a few of these:
>
> ERROR: do not initialise globals to 0 or NULL
> #90: FILE: drivers/net/wan/farsync.c:83:
> +int fst_excluded_cards = 0;
>
> Is this because when the module is loaded the globals are
> guaranteed to be zero'd already, or is the module init is expected
> to initialise them?
>
In C globals are always initialized to zero at the start.
I think there was a reason to prefer one way over the other with
older versions of GCC but now it's just a style preference or
something.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-31 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 7:20 [patch] farsync: fix support for over 30 cards Dan Carpenter
2012-10-09 7:20 ` Dan Carpenter
2012-10-09 17:55 ` David Miller
2012-10-09 17:55 ` David Miller
2013-07-26 10:13 ` Updated FarSync driver Kevin Curtis
2013-07-26 10:13 ` Kevin Curtis
2013-07-26 23:41 ` Dan Carpenter
2013-07-26 23:41 ` Dan Carpenter
2013-07-27 20:27 ` govind
2013-07-27 20:39 ` govind
2013-07-29 11:10 ` Dan Carpenter
2013-07-29 11:42 ` Dan Carpenter
2013-07-29 12:58 ` Kevin Curtis
2013-07-31 13:55 ` Kevin Curtis
2013-07-31 14:50 ` Dan Carpenter [this message]
2013-08-30 20:53 ` Dan Carpenter
2013-08-30 21:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731145017.GH5002@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.