From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 31 Jul 2013 22:18:04 +0200
Subject: [U-Boot] [PATCH v3 7/7] ARM: OMAP5-uevm: Add usb device reset
	API
In-Reply-To: <51F968E6.6050603@ti.com>
References: <1374092167-27645-1-git-send-email-dmurphy@ti.com>
	<201307180630.55940.marex@denx.de> <51F968E6.6050603@ti.com>
Message-ID: <201307312218.04862.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Dan Murphy,

> Marek
> 
> On 07/17/2013 11:30 PM, Marek Vasut wrote:
> > Dear Dan Murphy,
> > 
> >> Add the call back to reset the LAN9730 after
> >> the FEAT_POWER has been called.
> >> 
> >> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> >> ---
> >> v3 - Added this patch to separate the patch series -
> >> http://patchwork.ozlabs.org/patch/258229/
> >> 
> >>  board/ti/omap5_uevm/evm.c |   11 +++++++++++
> >>  1 file changed, 11 insertions(+)
> >> 
> >> diff --git a/board/ti/omap5_uevm/evm.c b/board/ti/omap5_uevm/evm.c
> >> index 9add0fd..42253fd 100644
> >> --- a/board/ti/omap5_uevm/evm.c
> >> +++ b/board/ti/omap5_uevm/evm.c
> >> @@ -31,6 +31,7 @@
> >> 
> >>  #ifdef CONFIG_USB_EHCI
> >>  #include <usb.h>
> >> 
> >> +#include <asm/gpio.h>
> >> 
> >>  #include <asm/arch/ehci.h>
> >>  #include <asm/ehci-omap.h>
> >> 
> >> @@ -169,4 +170,14 @@ int ehci_hcd_stop(void)
> >> 
> >>  	ret = omap_ehci_hcd_stop();
> >>  	return ret;
> >>  
> >>  }
> >> 
> >> +
> >> +void usb_hub_reset_devices(int port)
> >> +{
> >> +	/* The LAN9730 needs to be reset after the port power has been set. */
> >> +	if (port == 3) {
> >> +		gpio_direction_output(CONFIG_OMAP_EHCI_PHY1_RESET_GPIO, 0);
> >> +		udelay(10);
> >> +		gpio_direction_output(CONFIG_OMAP_EHCI_PHY1_RESET_GPIO, 1);
> >> +	}
> >> +}
> > 
> > Do you really need a config option for a board-specific GPIO used in a
> > board file?
> 
> Sorry I missed addressing this comment.
> 
> I am not adding a config option but I am re-using the CONFIG option that
> already exists. I did not want to define the GPIO number twice.
> 
> This CONFIG option is also used in the ehci-omap.c file.

OK. I can't say I'm happy about it being called CONFIG_ tho, maybe this can be 
fixed (in later patch).

Best regards,
Marek Vasut