From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34856)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V4uVm-0007sB-2W
	for qemu-devel@nongnu.org; Thu, 01 Aug 2013 11:09:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V4uVf-0003Dv-Si
	for qemu-devel@nongnu.org; Thu, 01 Aug 2013 11:09:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35057)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1V4uVf-0003Dl-ML
	for qemu-devel@nongnu.org; Thu, 01 Aug 2013 11:09:47 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r71F9k0r006258
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 1 Aug 2013 11:09:46 -0400
Date: Thu, 1 Aug 2013 17:09:44 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130801150944.GG2387@stefanha-thinkpad.redhat.com>
References: <cover.1375325971.git.jcody@redhat.com>
	<a1228129c5be1851c269658d8b40db632fa198a1.1375325971.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a1228129c5be1851c269658d8b40db632fa198a1.1375325971.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 6/9] block: vhdx - update log guid in
 header, and first write tracker
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org

On Wed, Jul 31, 2013 at 11:23:51PM -0400, Jeff Cody wrote:
> @@ -998,6 +1006,16 @@ exit:
>  
>  
>  
> +/* Per the spec, on the first write of guest-visible data to the file the
> + * data write guid must be updated in the header */
> +void vhdx_user_visible_write(BlockDriverState *bs, BDRVVHDXState *s)
> +{
> +    if (s->first_visible_write) {
> +        s->first_visible_write = false;
> +        vhdx_update_headers(bs, s, true, NULL);

Error handling is missing.