All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fredrik Gustafsson <iveqy@iveqy.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Stefan Beller <stefanbeller@googlemail.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Rewriting git-repack.sh in C
Date: Sat, 3 Aug 2013 08:33:25 +0200	[thread overview]
Message-ID: <20130803063325.GJ19369@paksenarrion.iveqy.com> (raw)
In-Reply-To: <CACsJy8CaTA2vT0CxOAm0FacCWjNDJjZhg6mwSyspTChia-5ppQ@mail.gmail.com>

On Fri, Aug 02, 2013 at 09:10:59PM +0700, Duy Nguyen wrote:
> > So my question is, how you'd generally approach rewriting a
> > shell script in C.
> 
> Start a new process via start_command/run_command interface. It's
> safer to retain the process boundary at this stage. You can try to
> integrate further later.

Is it really the right approach to just replace sh with C? IMHO forking
and wait for the result should not be done if it can be avoided. It just
adds overhead.

Of course you can argue that just replace sh with C is a good first step
towards to actually do the command in "full C". Altough I'm afraid that
that will get such low priority that it won't be done.

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com

  parent reply	other threads:[~2013-08-03  6:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02 13:48 Rewriting git-repack.sh in C Stefan Beller
2013-08-02 14:10 ` Duy Nguyen
2013-08-02 16:36   ` Duy Nguyen
2013-08-03  6:33   ` Fredrik Gustafsson [this message]
2013-08-03 10:03     ` Duy Nguyen
2013-08-07 14:00       ` [PATCH 0/4] " Stefan Beller
2013-08-07 14:00         ` [PATCH 1/4] Build in git-repack Stefan Beller
2013-08-07 14:28           ` Matthieu Moy
2013-08-07 15:48             ` Junio C Hamano
2013-08-07 16:45               ` Stefan Beller
2013-08-08  2:44               ` Duy Nguyen
2013-08-07 14:00         ` [PATCH 2/4] backup_file dummy function Stefan Beller
2013-08-08  2:45           ` Duy Nguyen
2013-08-07 14:00         ` [PATCH 3/4] pack-objects: do not print usage when repacking Stefan Beller
2013-08-08  6:40           ` Antoine Pelisse
2013-08-07 14:00         ` [PATCH 4/4] repack: add unpack-unreachable Stefan Beller
2013-08-05 10:34 ` Rewriting git-repack.sh in C Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130803063325.GJ19369@paksenarrion.iveqy.com \
    --to=iveqy@iveqy.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=stefanbeller@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.