From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1V6M0F-00007v-ND
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 10:43:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1V6M08-0005ZZ-FO
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 10:43:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51431)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1V6M08-0005Z4-7j
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 10:43:12 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r75EhAet032261
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 5 Aug 2013 10:43:10 -0400
Date: Mon, 5 Aug 2013 10:43:08 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20130805144308.GA19080@localhost.localdomain>
References: <cover.1375325971.git.jcody@redhat.com>
	<595d71cf1cd25ac9deff521bceb82b8c3da888d0.1375325971.git.jcody@redhat.com>
	<20130805114232.GF2654@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130805114232.GF2654@dhcp-200-207.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update
	capability.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Aug 05, 2013 at 01:42:32PM +0200, Kevin Wolf wrote:
> Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> > This adds the ability to update the headers in a VHDX image, including
> > generating a new MS-compatible GUID.
> > 
> > As VHDX depends on uuid.h, VHDX is now a configurable build option.  If
> > VHDX support is enabled, that will also enable uuid as well.  The
> > default is to have VHDX enabled.
> > 
> > To enable/disable VHDX:  --enable-vhdx, --disable-vhdx
> > 
> > Signed-off-by: Jeff Cody <jcody@redhat.com>
> 
> > diff --git a/configure b/configure
> > index 877a821..821b790 100755
> > --- a/configure
> > +++ b/configure
> > @@ -244,6 +244,7 @@ gtk=""
> >  gtkabi="2.0"
> >  tpm="no"
> >  libssh2=""
> > +vhdx="yes"
> >  
> >  # parse CC options first
> >  for opt do
> > @@ -950,6 +951,11 @@ for opt do
> >    ;;
> >    --enable-libssh2) libssh2="yes"
> >    ;;
> > +  --enable-vhdx) vhdx="yes" ;
> > +                 uuid="yes"
> > +  ;;
> 
> What's this? Shouldn't auto-detecting uuid and checking later whether
> it's available do the right thing?
>

You are right, thanks.  Will fix for v3.

> Test cases:
> 
> 1. configure --disable-uuid --enable-vhdx
>    This should result in an error because the options contradict each
>    other. With this patch, the disable flag is overridden.
> 
> 2. No libuuid headers available; ./configure
>    Should build without VHDX. With this patch, uuid is left out, vhdx is
>    configured anyway, the build fails.
> 
> Kevin