From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability.
Date: Mon, 5 Aug 2013 17:05:36 +0200 [thread overview]
Message-ID: <20130805150536.GK2654@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <595d71cf1cd25ac9deff521bceb82b8c3da888d0.1375325971.git.jcody@redhat.com>
Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> This adds the ability to update the headers in a VHDX image, including
> generating a new MS-compatible GUID.
>
> As VHDX depends on uuid.h, VHDX is now a configurable build option. If
> VHDX support is enabled, that will also enable uuid as well. The
> default is to have VHDX enabled.
>
> To enable/disable VHDX: --enable-vhdx, --disable-vhdx
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
I knew I'd forget to mention something I had seen...
> + /* overwrite the actual VHDXHeader portion */
> + memcpy(buffer, inactive_header, sizeof(VHDXHeader));
> + inactive_header->checksum = vhdx_update_checksum(buffer,
> + VHDX_HEADER_SIZE, 4);
This I would prefer as offsetof(VHDXHeader, checksum) instead of a magic
number 4.
Kevin
next prev parent reply other threads:[~2013-08-05 15:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 3:23 [Qemu-devel] [PATCH v2 0/9] VHDX log replay and write support Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 1/9] block: vhdx - minor comments and typo correction Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability Jeff Cody
2013-08-01 13:44 ` Stefan Hajnoczi
2013-08-01 14:09 ` Jeff Cody
2013-08-07 14:42 ` Jeff Cody
2013-08-05 11:42 ` Kevin Wolf
2013-08-05 14:43 ` Jeff Cody
2013-08-05 14:45 ` Kevin Wolf
2013-08-05 14:57 ` Jeff Cody
2013-08-05 15:05 ` Kevin Wolf [this message]
2013-08-05 15:09 ` Jeff Cody
2013-08-06 8:34 ` Kevin Wolf
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 3/9] block: vhdx code movement - VHDXMetadataEntries and BDRVVHDXState to header Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines Jeff Cody
2013-08-01 15:00 ` Stefan Hajnoczi
2013-08-01 15:51 ` Jeff Cody
2013-08-07 15:22 ` Kevin Wolf
2013-08-07 17:18 ` Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 5/9] block: vhdx - break endian translation functions out Jeff Cody
2013-08-01 15:03 ` Stefan Hajnoczi
2013-08-01 15:14 ` Jeff Cody
2013-08-07 15:29 ` Kevin Wolf
2013-08-07 17:21 ` Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 6/9] block: vhdx - update log guid in header, and first write tracker Jeff Cody
2013-08-01 15:09 ` Stefan Hajnoczi
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 7/9] block: vhdx - log parsing, replay, and flush support Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 8/9] block: vhdx - add log write support Jeff Cody
2013-08-01 3:23 ` [Qemu-devel] [PATCH v2 9/9] block: vhdx " Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805150536.GK2654@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.