From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6MwC-000314-3v for qemu-devel@nongnu.org; Mon, 05 Aug 2013 11:43:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6Mw6-0003Oj-2x for qemu-devel@nongnu.org; Mon, 05 Aug 2013 11:43:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6Mw5-0003Oe-RP for qemu-devel@nongnu.org; Mon, 05 Aug 2013 11:43:06 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r75F9xC0015629 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 5 Aug 2013 11:10:00 -0400 Date: Mon, 5 Aug 2013 11:09:56 -0400 From: Jeff Cody Message-ID: <20130805150956.GC19080@localhost.localdomain> References: <595d71cf1cd25ac9deff521bceb82b8c3da888d0.1375325971.git.jcody@redhat.com> <20130805150536.GK2654@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130805150536.GK2654@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/9] block: vhdx - add header update capability. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Aug 05, 2013 at 05:05:36PM +0200, Kevin Wolf wrote: > Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben: > > This adds the ability to update the headers in a VHDX image, including > > generating a new MS-compatible GUID. > > > > As VHDX depends on uuid.h, VHDX is now a configurable build option. If > > VHDX support is enabled, that will also enable uuid as well. The > > default is to have VHDX enabled. > > > > To enable/disable VHDX: --enable-vhdx, --disable-vhdx > > > > Signed-off-by: Jeff Cody > > I knew I'd forget to mention something I had seen... > > > + /* overwrite the actual VHDXHeader portion */ > > + memcpy(buffer, inactive_header, sizeof(VHDXHeader)); > > + inactive_header->checksum = vhdx_update_checksum(buffer, > > + VHDX_HEADER_SIZE, 4); > > This I would prefer as offsetof(VHDXHeader, checksum) instead of a magic > number 4. Who doesn't like a little bit of magic? :) OK, I'll use offsetof() (I'll also look through the rest of my patches for similar occurrences as well). Jeff