From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6eDj-0004uM-6Q
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:10:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6eDd-0002xe-BG
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:10:27 -0400
Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:37059)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1V6eDd-0002xG-3M
	for qemu-devel@nongnu.org; Tue, 06 Aug 2013 06:10:21 -0400
Received: by mail-we0-f176.google.com with SMTP id q56so170883wes.21
	for <qemu-devel@nongnu.org>; Tue, 06 Aug 2013 03:10:20 -0700 (PDT)
Date: Tue, 6 Aug 2013 12:10:17 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130806101017.GA7439@stefanha-thinkpad.redhat.com>
References: <714109BBB1F743A30290732C@nimrod.local>
	<1375639805-1943-1-git-send-email-alex@alex.org.uk>
	<1375639805-1943-7-git-send-email-alex@alex.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375639805-1943-7-git-send-email-alex@alex.org.uk>
Subject: Re: [Qemu-devel] [RFC] [PATCHv5 06/16] aio / timers: Untangle
 include files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

On Sun, Aug 04, 2013 at 07:09:55PM +0100, Alex Bligh wrote:
> include/qemu/timer.h has no need to include main-loop.h and
> doing so causes an issue for the next patch. Unfortunately
> various files assume including timers.h will pull in main-loop.h.
> Untangle this mess.
> 
> Signed-off-by: Alex Bligh <alex@alex.org.uk>
> ---
>  dma-helpers.c             |    1 +
>  hw/dma/xilinx_axidma.c    |    1 +
>  hw/timer/arm_timer.c      |    1 +
>  hw/timer/grlib_gptimer.c  |    2 ++
>  hw/timer/imx_epit.c       |    1 +
>  hw/timer/imx_gpt.c        |    1 +
>  hw/timer/lm32_timer.c     |    1 +
>  hw/timer/puv3_ost.c       |    1 +
>  hw/timer/slavio_timer.c   |    1 +
>  hw/timer/xilinx_timer.c   |    1 +
>  hw/usb/hcd-uhci.c         |    1 +
>  include/block/block_int.h |    1 +
>  include/block/coroutine.h |    2 ++
>  include/qemu/timer.h      |    1 -
>  migration-exec.c          |    1 +
>  migration-fd.c            |    1 +
>  migration-tcp.c           |    1 +
>  migration-unix.c          |    1 +
>  migration.c               |    1 +
>  nbd.c                     |    1 +
>  net/net.c                 |    1 +
>  net/socket.c              |    1 +
>  qemu-coroutine-io.c       |    1 +
>  qemu-io-cmds.c            |    1 +
>  qemu-nbd.c                |    1 +
>  slirp/misc.c              |    1 +
>  thread-pool.c             |    1 +
>  ui/vnc-auth-vencrypt.c    |    2 +-
>  ui/vnc-ws.c               |    1 +
>  29 files changed, 30 insertions(+), 2 deletions(-)

Fails to build ui/vnc-auth-sasl.c

Please make sure that your ./configure output shows most optional
dependencies are available (you need to install development packages for
these libraries).  Otherwise you will not see build breakage.

Stefan