From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dkim1.fusionio.com ([66.114.96.53]:34732 "EHLO dkim1.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030282Ab3HIOfj (ORCPT ); Fri, 9 Aug 2013 10:35:39 -0400 Received: from mx2.fusionio.com (unknown [10.101.1.160]) by dkim1.fusionio.com (Postfix) with ESMTP id 2C3747C067B for ; Fri, 9 Aug 2013 08:35:39 -0600 (MDT) Date: Fri, 9 Aug 2013 10:35:37 -0400 From: Josef Bacik To: Andreas Schwab CC: Josef Bacik , Thorsten Glaser , Joe Perches , Geert Uytterhoeven , Debian GNU/Linux m68k , , Linux Kernel Development Subject: Re: btrfs zero divide Message-ID: <20130809143537.GA861@localhost.localdomain> References: <20130730171329.GF24583@localhost.localdomain> <20130730204001.GG24583@localhost.localdomain> <87eha33v9f.fsf@igel.home> <87a9kr3v2p.fsf@igel.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <87a9kr3v2p.fsf@igel.home> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Aug 09, 2013 at 02:30:38PM +0200, Andreas Schwab wrote: > Andreas Schwab writes: > > > Josef Bacik writes: > > > >> So stripe_len shouldn't be 0, if it is you have bigger problems :). > > > > The bigger problem is that stripe_nr is u64, this is completely bogus. > > The first operand of do_div must be u32. This goes through the whole > > file. > > Of course, what I meant was that the *second* operand must be u32, but > that doesn't change my point. > Yeah we can change this. Thanks, Josef