From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030709Ab3HIOmq (ORCPT ); Fri, 9 Aug 2013 10:42:46 -0400 Received: from mga02.intel.com ([134.134.136.20]:37214 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030282Ab3HIOmo (ORCPT ); Fri, 9 Aug 2013 10:42:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,846,1367996400"; d="scan'208";a="384458981" From: "Kirill A. Shutemov" To: Ning Qu Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , Dave Hansen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1375582645-29274-1-git-send-email-kirill.shutemov@linux.intel.com> <1375582645-29274-21-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCH 20/23] thp: handle file pages in split_huge_page() Content-Transfer-Encoding: 7bit Message-Id: <20130809144601.159CAE0090@blue.fi.intel.com> Date: Fri, 9 Aug 2013 17:46:01 +0300 (EEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ning Qu wrote: > I just tried, and it seems working fine now without the deadlock anymore. I > can run some big internal test with about 40GB files in sysv shm. Just move > the line before the locking happens in vma_adjust, something as below, the > line number is not accurate because my patch is based on another tree right > now. Looks okay to me. Could you prepare real patch (description, etc.). I'll add it to my patchset. > > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -581,6 +581,8 @@ again: remove_next = 1 + (end > > next->vm_end); > } > } > > + vma_adjust_trans_huge(vma, start, end, adjust_next); > + > if (file) { > mapping = file->f_mapping; > if (!(vma->vm_flags & VM_NONLINEAR)) > @@ -597,8 +599,6 @@ again: remove_next = 1 + (end > > next->vm_end); > } > } > > - vma_adjust_trans_huge(vma, start, end, adjust_next); > - > anon_vma = vma->anon_vma; > if (!anon_vma && adjust_next) > anon_vma = next->anon_vma; > > > Best wishes, > -- > Ning Qu (曲宁) | Software Engineer | quning@google.com | +1-408-418-6066 -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH 20/23] thp: handle file pages in split_huge_page() Date: Fri, 9 Aug 2013 17:46:01 +0300 (EEST) Message-ID: <20130809144601.159CAE0090@blue.fi.intel.com> References: <1375582645-29274-1-git-send-email-kirill.shutemov@linux.intel.com> <1375582645-29274-21-git-send-email-kirill.shutemov@linux.intel.com> Content-Transfer-Encoding: 7bit Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , Dave Hansen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Ning Qu Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Ning Qu wrote: > I just tried, and it seems working fine now without the deadlock anymore. I > can run some big internal test with about 40GB files in sysv shm. Just move > the line before the locking happens in vma_adjust, something as below, the > line number is not accurate because my patch is based on another tree right > now. Looks okay to me. Could you prepare real patch (description, etc.). I'll add it to my patchset. > > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -581,6 +581,8 @@ again: remove_next = 1 + (end > > next->vm_end); > } > } > > + vma_adjust_trans_huge(vma, start, end, adjust_next); > + > if (file) { > mapping = file->f_mapping; > if (!(vma->vm_flags & VM_NONLINEAR)) > @@ -597,8 +599,6 @@ again: remove_next = 1 + (end > > next->vm_end); > } > } > > - vma_adjust_trans_huge(vma, start, end, adjust_next); > - > anon_vma = vma->anon_vma; > if (!anon_vma && adjust_next) > anon_vma = next->anon_vma; > > > Best wishes, > -- > Ning Qu (曲宁) | Software Engineer | quning@google.com | +1-408-418-6066 -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id 11E316B0031 for ; Fri, 9 Aug 2013 10:42:44 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1375582645-29274-1-git-send-email-kirill.shutemov@linux.intel.com> <1375582645-29274-21-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCH 20/23] thp: handle file pages in split_huge_page() Content-Transfer-Encoding: 7bit Message-Id: <20130809144601.159CAE0090@blue.fi.intel.com> Date: Fri, 9 Aug 2013 17:46:01 +0300 (EEST) Sender: owner-linux-mm@kvack.org List-ID: To: Ning Qu Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , Dave Hansen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Ning Qu wrote: > I just tried, and it seems working fine now without the deadlock anymore. I > can run some big internal test with about 40GB files in sysv shm. Just move > the line before the locking happens in vma_adjust, something as below, the > line number is not accurate because my patch is based on another tree right > now. Looks okay to me. Could you prepare real patch (description, etc.). I'll add it to my patchset. > > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -581,6 +581,8 @@ again: remove_next = 1 + (end > > next->vm_end); > } > } > > + vma_adjust_trans_huge(vma, start, end, adjust_next); > + > if (file) { > mapping = file->f_mapping; > if (!(vma->vm_flags & VM_NONLINEAR)) > @@ -597,8 +599,6 @@ again: remove_next = 1 + (end > > next->vm_end); > } > } > > - vma_adjust_trans_huge(vma, start, end, adjust_next); > - > anon_vma = vma->anon_vma; > if (!anon_vma && adjust_next) > anon_vma = next->anon_vma; > > > Best wishes, > -- > Ning Qu (ae?2a(R)?) | Software Engineer | quning@google.com | +1-408-418-6066 -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org