From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 03/25] drm/imx: kill firstopen callback Date: Mon, 12 Aug 2013 15:23:33 -0700 Message-ID: <20130812222333.GA2283@kroah.com> References: <1375969295-18929-1-git-send-email-daniel.vetter@ffwll.ch> <1375969295-18929-4-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTP id 2779FE5EEE for ; Mon, 12 Aug 2013 15:30:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375969295-18929-4-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 08, 2013 at 03:41:13PM +0200, Daniel Vetter wrote: > This thing seems to do some kind of delayed setup. Really, real kms > drivers shouldn't do that at all. Either stuff needs to be dynamically > hotplugged or the driver setup sequence needs to be fixed. > > This patch here just moves the setup at the very end of the driver > load callback, with the locking adjusted accordingly. > > v2: Also move the corresponding put from ->lastclose to ->unload. > > Cc: Sascha Hauer > Cc: Greg Kroah-Hartman > Signed-off-by: Daniel Vetter > --- > > Note that this is already in the staging tree but due to the follow-up cleanup > it's probably best to merge it again through drm-next. > -Daniel That's fine with me: Acked-by: Greg Kroah-Hartman