All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
	Lists linaro-kernel <linaro-kernel@lists.linaro.org>
Subject: Re: [PATCH] cpufreq: add frequency table to at32ap driver
Date: Tue, 13 Aug 2013 08:52:08 +0200	[thread overview]
Message-ID: <20130813065208.GB7055@samfundet.no> (raw)
In-Reply-To: <CAKohponh4tW8j3qk7eP9YnfXufutNkK-+iCQRvqSUC2=GwvqeA@mail.gmail.com>

Around Tue 13 Aug 2013 10:41:39 +0530 or thereabout, Viresh Kumar wrote:
> On 13 August 2013 10:38, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> Thanks for your patch, I have folded below patch with your patch while
>> applying..
> 
> And actually this too, otherwise I need to do this separately in another
> patch..
> 
> diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
> index c586d3e..1d19fa5 100644
> --- a/drivers/cpufreq/at32ap-cpufreq.c
> +++ b/drivers/cpufreq/at32ap-cpufreq.c
> @@ -136,15 +136,12 @@ static int __init
> at32_cpufreq_driver_init(struct cpufreq_policy *policy)
> 
>         freq_table[steps - 1].frequency = CPUFREQ_TABLE_END;
> 
> -       retval = cpufreq_frequency_table_cpuinfo(policy, freq_table);
> -       if (retval)
> -               goto out_err_kfree;
> -
> -       cpufreq_frequency_table_get_attr(freq_table, policy->cpu);
> -       printk("cpufreq: AT32AP CPU frequency driver\n");
> +       retval = cpufreq_table_validate_and_show(policy, freq_table);
> +       if (!retval) {
> +               printk("cpufreq: AT32AP CPU frequency driver\n");
> +               return 0;
> +       }
> 
> -       return 0;
> -out_err_kfree:
>         kfree(freq_table);
>  out_err_put_clk:
>         clk_put(cpuclk);

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

Thanks for cleaning up (-:

-- 
mvh
Hans-Christian Egtvedt

  reply	other threads:[~2013-08-13  6:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 19:10 [PATCH] cpufreq: add frequency table to at32ap driver Hans-Christian Egtvedt
2013-08-13  5:08 ` Viresh Kumar
2013-08-13  5:11   ` Viresh Kumar
2013-08-13  6:52     ` Hans-Christian Egtvedt [this message]
2013-08-13  6:58       ` Viresh Kumar
2013-08-13  9:06         ` Hans-Christian Egtvedt
2013-08-13  9:09           ` Viresh Kumar
2013-08-13 13:30             ` Viresh Kumar
2013-08-14  6:07               ` Hans-Christian Egtvedt
2013-08-14  6:09                 ` Viresh Kumar
2013-08-13  6:49   ` Hans-Christian Egtvedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813065208.GB7055@samfundet.no \
    --to=egtvedt@samfundet.no \
    --cc=cpufreq@vger.kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.