All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lidza Louina <lidza.louina@gmail.com>
Cc: Mark Hounschell <markh@compro.net>,
	Greg KH <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH 6/9] staging: dgnc: fixes error: incompatible types when assigning to type ‘struct ktermios *’ from type ‘struct ktermios’
Date: Tue, 13 Aug 2013 10:30:28 +0300	[thread overview]
Message-ID: <20130813073028.GQ5502@mwanda> (raw)
In-Reply-To: <1376341513-20578-7-git-send-email-lidza.louina@gmail.com>

On Mon, Aug 12, 2013 at 05:05:10PM -0400, Lidza Louina wrote:
> Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index a00fe2b..1e22b4b 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -1758,7 +1758,7 @@ static void dgnc_tty_close(struct tty_struct *tty, struct file *file)
>  	if (!bd || bd->magic != DGNC_BOARD_MAGIC)
>  		return;
>  
> -	ts = tty->termios;
> +	ts = &(tty->termios);

These parenthesis are not needed and look ugly.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2013-08-13  7:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 21:05 [PATCH 0/9] staging: dgnc: builds this driver into the kernel Lidza Louina
2013-08-12 21:05 ` [PATCH 1/9] staging: dgnc: removes Makefile.inc Lidza Louina
2013-08-12 21:13   ` Greg KH
2013-08-13  2:41     ` Lidza Louina
2013-08-12 21:05 ` [PATCH 2/9] staging: dgnc: builds into kernel Lidza Louina
2013-08-12 21:10   ` Greg KH
2013-08-13  2:22     ` Lidza Louina
2013-08-12 21:05 ` [PATCH 3/9] staging: dgnc: removes proc code Lidza Louina
2013-08-12 21:11   ` Greg KH
2013-08-13  2:32     ` Lidza Louina
2013-08-12 21:05 ` [PATCH 4/9] staging: dgnc: fixes error: invalid type argument of ‘->’ (have ‘struct ktermios’) Lidza Louina
2013-08-12 21:12   ` [PATCH 4/9] staging: dgnc: fixes error: invalid type argument of ‘->’ (have ���struct ktermios’) Greg KH
2013-08-12 21:05 ` [PATCH 5/9] staging: dgnc: fixes error: expected ‘struct tty_port *’ but argument is of type ‘struct tty_struct *’ Lidza Louina
2013-08-12 21:13   ` Greg KH
2013-08-12 21:05 ` [PATCH 6/9] staging: dgnc: fixes error: incompatible types when assigning to type ‘struct ktermios *’ from type ‘struct ktermios’ Lidza Louina
2013-08-12 21:14   ` Greg KH
2013-08-13  7:30   ` Dan Carpenter [this message]
2013-08-13 13:20     ` Lidza Louina
2013-08-12 21:05 ` [PATCH 7/9] staging: dgnc: fixes warning: initialization from incompatible pointer type Lidza Louina
2013-08-13  7:32   ` Dan Carpenter
2013-08-13 13:26     ` Lidza Louina
2013-08-12 21:05 ` [PATCH 8/9] staging: dgnc: removes read_cnt, real_raw and rawreadok Lidza Louina
2013-08-12 21:05 ` [PATCH 9/9] staging: dgnc: fixes warning: unused variable ‘buf’ Lidza Louina
2013-08-13  7:35   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813073028.GQ5502@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lidza.louina@gmail.com \
    --cc=markh@compro.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.