All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Benedikt Spranger <b.spranger@linutronix.de>
Cc: netdev@vger.kernel.org,
	Alexander Frank <Alexander.Frank@eberspaecher.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Holger Dengler <dengler@linutronix.de>
Subject: Re: [PATCH 4/7] mfd: add MFD based flexcard driver
Date: Tue, 13 Aug 2013 10:55:08 +0100	[thread overview]
Message-ID: <20130813095508.GA5109@lee--X1> (raw)
In-Reply-To: <1376384922-8519-6-git-send-email-b.spranger@linutronix.de>

On Tue, 13 Aug 2013, Benedikt Spranger wrote:

> This patch provides support for Eberpächer Flexcard. The Flexcard comes
> with two PCI bars, one for the glue layer and one for the "IPs". The
> second bar may have multiple other devices like flexray or d_can
> devices. The driver utilites the MFD framework and creates various
> subdevices. Not only for the additional "IPs" but also for the clock
> source and clockevent provided by the card.
> 
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
> Signed-off-by: Holger Dengler <dengler@linutronix.de>
> ---
>  drivers/mfd/Kconfig           |   40 ++
>  drivers/mfd/Makefile          |    2 +
>  drivers/mfd/flexcard-core.c   | 1059 +++++++++++++++++++++++++++++++++++++++++
>  drivers/mfd/flexcard-dma.c    |  561 ++++++++++++++++++++++
>  drivers/mfd/flexcard-irq.c    |  333 +++++++++++++
>  drivers/mfd/flexcard.h        |    8 +
>  include/linux/eray.h          |  650 +++++++++++++++++++++++++
>  include/linux/flexcard.h      |   95 ++++
>  include/uapi/linux/Kbuild     |    2 +
>  include/uapi/linux/eray.h     |   34 ++
>  include/uapi/linux/flexcard.h |  429 +++++++++++++++++
>  11 files changed, 3213 insertions(+)
>  create mode 100644 drivers/mfd/flexcard-core.c
>  create mode 100644 drivers/mfd/flexcard-dma.c
>  create mode 100644 drivers/mfd/flexcard-irq.c
>  create mode 100644 drivers/mfd/flexcard.h
>  create mode 100644 include/linux/eray.h
>  create mode 100644 include/linux/flexcard.h
>  create mode 100644 include/uapi/linux/eray.h
>  create mode 100644 include/uapi/linux/flexcard.h

Wow, this is a huge patch which is going to be an insanely long,
laborious and complex task to review it all.

Can you split this up into many patches? Adding functionality
incrementally instead of rolling it up into this ball of wax?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2013-08-13  9:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13  9:08 [PATCH 0/7] add FlexRay support Benedikt Spranger
2013-08-13  9:08 ` Benedikt Spranger
2013-08-13  9:08 ` [PATCH 1/7] uio: add module owner to prevent inappropriate module unloading Benedikt Spranger
2013-08-13 17:48   ` Greg Kroah-Hartman
2013-08-14  7:19     ` Benedikt Spranger
2013-08-14 16:33       ` Greg Kroah-Hartman
2013-08-15  6:42         ` Benedikt Spranger
2013-08-15  6:59           ` Greg Kroah-Hartman
2013-08-15  7:27             ` Benedikt Spranger
2013-08-15  8:09               ` Greg Kroah-Hartman
2013-08-15  8:18                 ` Sebastian Andrzej Siewior
2013-08-15 15:55                   ` Greg Kroah-Hartman
2013-08-15 16:03                     ` Sebastian Andrzej Siewior
2013-08-15 16:42                       ` Greg Kroah-Hartman
2013-08-15 16:54                         ` Sebastian Andrzej Siewior
2013-08-15 17:13                           ` Greg Kroah-Hartman
2013-08-13  9:08 ` [PATCH 2/7] uio: Allow to create custom UIO attributes Benedikt Spranger
2013-08-13 17:54   ` Greg Kroah-Hartman
2013-08-13  9:08 ` [PATCH 3/7] mfd: core: copy DMA mask and params from parent Benedikt Spranger
2013-08-13 10:03   ` Lee Jones
2013-08-13  9:08 ` [PATCH 4/7] mfd: add MFD based flexcard driver Benedikt Spranger
2013-08-13  9:55   ` Lee Jones [this message]
2013-08-14  8:12     ` Benedikt Spranger
2013-08-14  9:45       ` Lee Jones
2013-08-13  9:08 ` [PATCH 5/7] clocksource: Add flexcard support Benedikt Spranger
2013-08-13  9:08 ` [PATCH 6/7] net: add the AF_FLEXRAY protocol Benedikt Spranger
2013-08-18 18:50   ` Oliver Hartkopp
2013-08-13  9:08 ` [PATCH 7/7] net: add a flexray driver Benedikt Spranger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813095508.GA5109@lee--X1 \
    --to=lee.jones@linaro.org \
    --cc=Alexander.Frank@eberspaecher.com \
    --cc=b.spranger@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=dengler@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.