From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Rodrigo Vivi <rodrigo.vivi@gmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Fix __wait_seqno to use true infinite timeouts
Date: Tue, 13 Aug 2013 16:04:44 +0200 [thread overview]
Message-ID: <20130813140444.GD9296@phenom.ffwll.local> (raw)
In-Reply-To: <20130813133955.GA4827@cantiga.alporthouse.com>
On Tue, Aug 13, 2013 at 02:39:55PM +0100, Chris Wilson wrote:
> On Tue, Aug 13, 2013 at 10:36:04AM -0300, Rodrigo Vivi wrote:
> > applied to experimental drm-intel-collector.
> >
> > drivers/gpu/drm/i915/i915_gem.c: In function ‘__wait_seqno’:
> > drivers/gpu/drm/i915/i915_gem.c:1033:20: warning: ‘timeout_jiffies’ may be used
> > +uninitialized in this function
>
> Dumb gcc.
>
> Note the lack of sign-off. Ben would hate this patch since it may unmask
> simulator bugs.
Hm, I'd prefer it with sob line since I very much want to again have good
reporting on missed interrupts (instead of silently papering over them).
If the simulator is broken we need to apply special duct-tape for it
(maybe in the form of a timer that regularly checks the seqno), since 1s
delay is simply too slow, even for simulators.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-08-13 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 1:03 [PATCH] drm/i915: Fix __wait_seqno to use true infinite timeouts Chris Wilson
2013-08-13 13:36 ` Rodrigo Vivi
2013-08-13 13:39 ` Chris Wilson
2013-08-13 14:04 ` Daniel Vetter [this message]
2013-08-23 1:05 Chris Wilson
2013-08-23 7:27 ` Daniel Vetter
2013-08-23 8:06 ` Chris Wilson
2013-08-23 8:37 ` Daniel Vetter
2013-08-23 11:12 Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813140444.GD9296@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.