From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9c2B-00055i-Gb for qemu-devel@nongnu.org; Wed, 14 Aug 2013 10:26:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9c26-0007RK-Qf for qemu-devel@nongnu.org; Wed, 14 Aug 2013 10:26:47 -0400 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:33711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9c26-0007R3-Ke for qemu-devel@nongnu.org; Wed, 14 Aug 2013 10:26:42 -0400 Received: by mail-ea0-f176.google.com with SMTP id q16so4789694ead.21 for ; Wed, 14 Aug 2013 07:26:41 -0700 (PDT) Date: Wed, 14 Aug 2013 16:26:39 +0200 From: Stefan Hajnoczi Message-ID: <20130814142639.GC28912@stefanha-thinkpad.redhat.com> References: <1376070245-22557-1-git-send-email-charlie@ctshepherd.com> <1376070245-22557-3-git-send-email-charlie@ctshepherd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376070245-22557-3-git-send-email-charlie@ctshepherd.com> Subject: Re: [Qemu-devel] [RFC v2 03/15] Explicitly mark BlockDriver function .bdrv_create as coroutine and rename it bdrv_co_create. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Charlie Shepherd Cc: kwolf@redhat.com, pbonzini@redhat.com, gabriel@kerneis.info, qemu-devel@nongnu.org On Fri, Aug 09, 2013 at 07:43:53PM +0200, Charlie Shepherd wrote: > diff --git a/block/cow.c b/block/cow.c > index 1cc2e89..34c181a 100644 > --- a/block/cow.c > +++ b/block/cow.c > @@ -255,7 +255,7 @@ static void cow_close(BlockDriverState *bs) > { > } > > -static int cow_create(const char *filename, QEMUOptionParameter *options) > +static int coroutine_fn cow_co_create(const char *filename, QEMUOptionParameter *options) Please run scripts/checkpatch.pl on your patches. QEMU coding style enforces 80-character lines. See here to automatically run it during git-commit(1): http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html