All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH V11 13/15] perf tools: expand perf_event__synthesize_sample()
Date: Wed, 14 Aug 2013 18:39:06 +0200	[thread overview]
Message-ID: <20130814163906.GB1017@krava.brq.redhat.com> (raw)
In-Reply-To: <1376484517-5339-14-git-send-email-adrian.hunter@intel.com>

On Wed, Aug 14, 2013 at 03:48:35PM +0300, Adrian Hunter wrote:

SNIP

> index 81c170f..4c97f36 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1389,7 +1389,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
>  	}
>  
>  	if (type & PERF_SAMPLE_REGS_USER) {
> -		/* First u64 tells us if we have any regs in sample. */

;-)

>  		OVERFLOW_CHECK_u64(array);
>  		data->user_regs.abi = *array;

SNIP

> +
> +	if (type & PERF_SAMPLE_REGS_USER) {
> +		if (sample->user_regs.abi) {
> +			*array++ = sample->user_regs.abi;
> +			sz = hweight_long(sample_regs_user) * sizeof(u64);
> +			memcpy(array, sample->user_regs.regs, sz);
> +			array = (void *)array + sz;
> +		} else {
> +			*array++ = 0;
> +		}
> +	}

Acked-by: Jiri Olsa <jolsa@redhat.com>

  reply	other threads:[~2013-08-14 16:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 12:48 [PATCH V11 00/15] perf tools: some fixes and tweaks Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 01/15] perf tools: re-implement debug print function for linking python/perf.so Adrian Hunter
2013-08-29 10:07   ` [tip:perf/core] perf tools: Re-implement " tip-bot for Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 02/15] perf tools: add debug prints Adrian Hunter
2013-08-29 10:07   ` [tip:perf/core] perf tools: Add " tip-bot for Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 03/15] perf tools: allow non-matching sample types Adrian Hunter
2013-08-16 18:41   ` Arnaldo Carvalho de Melo
2013-08-18 19:04     ` Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 04/15] perf tools: add pid to struct thread Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 05/15] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 06/15] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 07/15] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 08/15] perf tools: remove references to struct ip_event Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 09/15] perf: make events stream always parsable Adrian Hunter
2013-08-14 13:00   ` Adrian Hunter
2013-08-21 13:39     ` Stephane Eranian
2013-08-14 12:48 ` [PATCH V11 10/15] perf tools: move perf_evlist__config() to a new source file Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 11/15] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 12/15] perf tools: add missing 'abi' member to 'struct regs_dump' Adrian Hunter
2013-08-14 16:36   ` Jiri Olsa
2013-08-14 12:48 ` [PATCH V11 13/15] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-08-14 16:39   ` Jiri Olsa [this message]
2013-08-14 12:48 ` [PATCH V11 14/15] perf tools: add a function to calculate sample event size Adrian Hunter
2013-08-14 12:48 ` [PATCH V11 15/15] perf tools: add a sample parsing test Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814163906.GB1017@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@ghostprotocols.net \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.