From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35187)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VAM4X-0005pD-2d
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 11:36:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VAM4O-0000VK-Ah
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 11:36:17 -0400
Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:43945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VAM4O-0000V9-2u
	for qemu-devel@nongnu.org; Fri, 16 Aug 2013 11:36:08 -0400
Received: by mail-wi0-f171.google.com with SMTP id hr7so983022wib.16
	for <qemu-devel@nongnu.org>; Fri, 16 Aug 2013 08:36:07 -0700 (PDT)
Date: Fri, 16 Aug 2013 17:36:04 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130816153604.GB24852@stefanha-thinkpad.redhat.com>
References: <1375844419-7665-1-git-send-email-xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1375844419-7665-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V7 0/8] add internal snapshot support at
 block device level
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: phrdina@redhat.com, famz@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com

On Wed, Aug 07, 2013 at 11:00:11AM +0800, Wenchao Xia wrote:
> v6:
>   Address Stefan's comments:
>   2/8: macro STR_PRINT_CHAR was renamed as STR_OR_NULL, and moved into patch 5,
> since implement function in this patch do not printf snapshot id any more, as
> Kevin's suggestion.

Great.

>   Address Kevin's comments:
>   2/8: remove device, id, name info in the error message, use error message in
> existing caller. A new function bdrv_snapshot_delete_by_id_or_name() is added
> to make the usage clear while keep logic unchanged. 
>   3/8: remove device info in error message when name is empty. Use else if
> after call of bdrv_snapshot_find_by_id_and_name().
>   Other:
>   2/8: refined the comments in code for bdrv_snapshot_delete().
>   3/8: in error reporting, change format from "reason is: '%s'" to
> "reason is: %s".

Kevin: do you have time to review these changes?

Stefan