From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754761Ab3HPRiz (ORCPT ); Fri, 16 Aug 2013 13:38:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:19406 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824Ab3HPRiv (ORCPT ); Fri, 16 Aug 2013 13:38:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,896,1367996400"; d="scan'208";a="388335279" Date: Fri, 16 Aug 2013 10:38:50 -0700 From: Sarah Sharp To: Greg KH Cc: Dmitry Kasatkin , linux-kernel@vger.kernel.org, dmitry.kasatkin@gmail.com Subject: Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled Message-ID: <20130816173850.GC7975@xanatos> References: <71bb3fcd9f1a99aa7bd8f6dd1fb6267173db51d2.1376582695.git.d.kasatkin@samsung.com> <70b3564625bbda6247cc5627041344fef8a762ae.1376582695.git.d.kasatkin@samsung.com> <20130816001716.GA7367@kroah.com> <20130816172635.GA7975@xanatos> <20130816173035.GA15607@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130816173035.GA15607@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2013 at 10:30:35AM -0700, Greg KH wrote: > On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: > > On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote: > > > On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: > > > > When debug is not enabled and dev_dbg() will expand to nothing, > > > > log might be flooded with "callbacks suppressed". If it was not > > > > done on purpose, better to use dev_dbg_ratelimited() instead. > > > > > > > > Signed-off-by: Dmitry Kasatkin > > > > --- > > > > drivers/usb/host/xhci-ring.c | 6 ++---- > > > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > > > > > > Sarah, does this patch conflict with the trace debug patches being > > > worked on? I'll hold off on applying it for now, let me know if it's ok > > > or not. > > > > It doesn't conflict with the trace debug patches, because those only > > effect debugging with xhci_dbg with the host device, not dev_dbg with > > the USB device. This should apply fine to usb-next. > > Ok, can I get your ack for it so I can apply it? Dmitry, can you fix the indentation issue and resubmit this? I'll ack it then. Sarah Sharp