From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] [v2] drm/i915/vma: Correct use after free
	in eviction
Date: Fri, 16 Aug 2013 23:31:12 +0100
Message-ID: <20130816223112.GA9822@nuc-i3427.alporthouse.com>
References: <1376675024-779-1-git-send-email-benjamin.widawsky@intel.com>
	<1376684973-14743-1-git-send-email-benjamin.widawsky@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (s16502780.onlinehome-server.info
	[87.106.93.118])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8592EE6087
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 16 Aug 2013 15:31:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1376684973-14743-1-git-send-email-benjamin.widawsky@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Aug 16, 2013 at 01:29:33PM -0700, Ben Widawsky wrote:
> The vma will [possibly] be destroyed during unbind in eviction.
> Immediately after this, we try to delete the list entry.
> =

> Chris and Ville did the debug on this before I woke up, I just get to
> take credit for the fix :p
> =

> v2: Missed the drm_object_unreference use after free (Ville)
> =

> Reported-by: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Should have spotted this earlier :(

Can I have a couple more lines of whitespace?
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- =

Chris Wilson, Intel Open Source Technology Centre