From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163Ab3HVVTW (ORCPT ); Thu, 22 Aug 2013 17:19:22 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:44024 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366Ab3HVVTV (ORCPT ); Thu, 22 Aug 2013 17:19:21 -0400 Date: Thu, 22 Aug 2013 23:19:12 +0200 From: Sascha Hauer To: Lee Jones Cc: Mark Rutland , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , "devicetree@vger.kernel.org" Subject: Re: [PATCH 09/33] ARM: ux500: Supply the I2C clocks lookup to the DBX500 DT Message-ID: <20130822211912.GE31036@pengutronix.de> Mail-Followup-To: Lee Jones , Mark Rutland , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , "devicetree@vger.kernel.org" References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-10-git-send-email-lee.jones@linaro.org> <20130820093034.GL31036@pengutronix.de> <20130822133730.GB23152@e106331-lin.cambridge.arm.com> <20130822141900.GB17154@lee--X1> <20130822151723.GE23152@e106331-lin.cambridge.arm.com> <20130822154116.GC17154@lee--X1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130822154116.GC17154@lee--X1> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 23:10:49 up 23 days, 6:15, 32 users, load average: 0.03, 0.04, 0.05 User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:5054:ff:fec0:8e10 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2013 at 04:41:16PM +0100, Lee Jones wrote: > > When most of the other clocks that we deal with are being requested, > they rely on being index zero: > > drivers/i2c/busses/i2c-nomadik.c: dev->clk = clk_get(&adev->dev, NULL); Once a device has more than a single clock all clocks should have a connection id. clk_get(dev, NULL) should only be used for single clock devices. Look at drivers/clk/clkdev.c, there's some fuzzy matching involved when you pass NULL as connection id. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Thu, 22 Aug 2013 23:19:12 +0200 Subject: [PATCH 09/33] ARM: ux500: Supply the I2C clocks lookup to the DBX500 DT In-Reply-To: <20130822154116.GC17154@lee--X1> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-10-git-send-email-lee.jones@linaro.org> <20130820093034.GL31036@pengutronix.de> <20130822133730.GB23152@e106331-lin.cambridge.arm.com> <20130822141900.GB17154@lee--X1> <20130822151723.GE23152@e106331-lin.cambridge.arm.com> <20130822154116.GC17154@lee--X1> Message-ID: <20130822211912.GE31036@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 22, 2013 at 04:41:16PM +0100, Lee Jones wrote: > > When most of the other clocks that we deal with are being requested, > they rely on being index zero: > > drivers/i2c/busses/i2c-nomadik.c: dev->clk = clk_get(&adev->dev, NULL); Once a device has more than a single clock all clocks should have a connection id. clk_get(dev, NULL) should only be used for single clock devices. Look at drivers/clk/clkdev.c, there's some fuzzy matching involved when you pass NULL as connection id. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |